From: Christoph Hellwig <hch@caldera.de>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RFC] kthread abstraction
Date: Fri, 1 Feb 2002 18:07:21 +0100 [thread overview]
Message-ID: <20020201180721.A6623@caldera.de> (raw)
In-Reply-To: <20020201163818.A32551@caldera.de.suse.lists.linux.kernel> <p73d6zpno2u.fsf@oldwotan.suse.de>
In-Reply-To: <p73d6zpno2u.fsf@oldwotan.suse.de>; from ak@suse.de on Fri, Feb 01, 2002 at 05:50:33PM +0100
On Fri, Feb 01, 2002 at 05:50:33PM +0100, Andi Kleen wrote:
> Christoph Hellwig <hch@caldera.de> writes:
>
>
> > void *data;
> >
> > Opaque data for the thread's use.
>
> That requires to dynamically allocate and initialize kthread if you
> can have potentially multiple threads (= too much to write)
>
> I think it would be better to pass data as a separate argument.
> You can put the kthread and the data into a private structure on
> the stack, pass the address of it to kernel_thread and wait until the
> thread has read it using a completion.
Agreed. I will rework the patch to follow your suggestion.
Christoph
--
Of course it doesn't work. We've performed a software upgrade.
next prev parent reply other threads:[~2002-02-01 17:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20020201163818.A32551@caldera.de.suse.lists.linux.kernel>
2002-02-01 16:50 ` [PATCH][RFC] kthread abstraction Andi Kleen
2002-02-01 17:07 ` Christoph Hellwig [this message]
2002-02-01 17:17 ` Christoph Hellwig
2002-02-01 15:38 Christoph Hellwig
2002-02-01 16:32 ` Adam Keys
2002-02-01 16:40 ` Christoph Hellwig
2002-02-01 17:21 ` Dave Hansen
2002-02-01 17:23 ` Christoph Hellwig
2002-02-01 17:49 ` Dave Hansen
2002-02-01 17:50 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020201180721.A6623@caldera.de \
--to=hch@caldera.de \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox