fixup descriptions in pci-pc.c

fixup descriptions in pci-pc.c

[Oliver Feiler]

	Ok, this is just a cosmetic thing, but I see that in 2.5.3 the printk 
text in pci_fixup_via_northbridge_bug in pci-pc.c was changed

- printk("Trying to stomp on VIA Northbridge bug...\n");
+ printk("Disabling broken memory write queue.\n");

	Can't we change this to some meaningful output in 2.4.18 as well? It's 
still the old text with pre7.

Bye

Oliver

-- 
Oliver Feiler                                               kiza@gmx.net
http://www.lionking.org/~kiza/pgpkey              PGP key ID: 0x561D4FD2
http://www.lionking.org/~kiza/

Re: fixup descriptions in pci-pc.c

[Calin A. Culianu]

Good idea.  I frankly hate that message as its vague and stupid.  Heh.  I
actually wrote it... but I did it as a patch to an older message and I
didn't want to really change the poetic essence of the function I
modified.

Feel free to patch this yourself.  I am a bit afraid to bug alan and linus
and marcello with such a small change :)

-Calin

On Sun, 3
Feb 2002, Oliver Feiler wrote:

> 	Ok, this is just a cosmetic thing, but I see that in 2.5.3 the printk
> text in pci_fixup_via_northbridge_bug in pci-pc.c was changed
>
> - printk("Trying to stomp on VIA Northbridge bug...\n");
> + printk("Disabling broken memory write queue.\n");
>
> 	Can't we change this to some meaningful output in 2.4.18 as well? It's
> still the old text with pre7.
>
> Bye
>
> Oliver
>
>

Re: [Patch] (was: Re: fixup descriptions in pci-pc.c)

[Ragnar Hojland Espinosa]

On Mon, Feb 04, 2002 at 11:46:44AM +0100, Oliver Feiler wrote:
> Hello,
> 
> 	This just changes the printk in the via_northbridge_bug fixup to some 
> more meaningful output as it is already in 2.5.3. Please apply.
> 
> Oliver
> 
> --- linux-2.4.18-pre7/arch/i386/kernel/pci-pc.c	Sun Feb  3 14:56:48 2002
> +++ linux-2.4.18-pre7_testing/arch/i386/kernel/pci-pc.c	Mon Feb  4 11:30:37 2002
> @@ -1129,7 +1129,7 @@
>  
>  	pci_read_config_byte(d, where, &v);
>  	if (v & 0xe0) {
> -		printk("Trying to stomp on VIA Northbridge bug...\n");
> +		printk("Disabling broken memory write queue.\n");
>  		v &= 0x1f; /* clear bits 5, 6, 7 */
>  		pci_write_config_byte(d, where, v);
>  	}

Even more meaningful:

	"Disabling VIA Northbridge broken memory write queue.\n"

-- 
____/|  Ragnar Højland      Freedom - Linux - OpenGL |    Brainbench MVP
\ o.O|  PGP94C4B2F0D27DE025BE2302C104B78C56 B72F0822 | for Unix Programming
 =(_)=  "Thou shalt not follow the NULL pointer for  | (www.brainbench.com)
   U     chaos and madness await thee at its end."      [56 pend. Jan  8]

[Patch] (was: Re: fixup descriptions in pci-pc.c)

[Oliver Feiler]

Hello,

	This just changes the printk in the via_northbridge_bug fixup to some 
more meaningful output as it is already in 2.5.3. Please apply.

Oliver

--- linux-2.4.18-pre7/arch/i386/kernel/pci-pc.c	Sun Feb  3 14:56:48 2002
+++ linux-2.4.18-pre7_testing/arch/i386/kernel/pci-pc.c	Mon Feb  4 11:30:37 2002
@@ -1129,7 +1129,7 @@
 
 	pci_read_config_byte(d, where, &v);
 	if (v & 0xe0) {
-		printk("Trying to stomp on VIA Northbridge bug...\n");
+		printk("Disabling broken memory write queue.\n");
 		v &= 0x1f; /* clear bits 5, 6, 7 */
 		pci_write_config_byte(d, where, v);
 	}


-- 
Oliver Feiler                                               kiza@gmx.net
http://www.lionking.org/~kiza/pgpkey              PGP key ID: 0x561D4FD2
http://www.lionking.org/~kiza/

Re: fixup descriptions in pci-pc.c

[Oliver Feiler]

Denis Vlasenko wrote:
> 
> Probably. + [reg]: old->new or similar

	Ok. Better with this?


--- linux-2.4.18-pre7/arch/i386/kernel/pci-pc.c	Mon Feb  4 15:13:45 2002
+++ linux-2.4.18-pre7_testing/arch/i386/kernel/pci-pc.c	Mon Feb  4 15:15:13 2002
@@ -1129,7 +1129,7 @@
 
 	pci_read_config_byte(d, where, &v);
 	if (v & 0xe0) {
-		printk("Trying to stomp on VIA Northbridge bug...\n");
+		printk("Disabling VIA memory write queue. Clearing bits 5, 6, 7 at 0x%x.\n", where);
 		v &= 0x1f; /* clear bits 5, 6, 7 */
 		pci_write_config_byte(d, where, v);
 	}


-- 
Oliver Feiler                                               kiza@gmx.net
http://www.lionking.org/~kiza/pgpkey              PGP key ID: 0x561D4FD2
http://www.lionking.org/~kiza/

Re: [Patch] (was: Re: fixup descriptions in pci-pc.c)

[Calin A. Culianu]

Woo hoo!  The new message is much better!!

Also, speaking of the pci-pc.c fixup for via.. I hear for some people it
causes massive system instability.. :(  Although for me it was the
answer to my woes.  What to do about that?

-Calin

On Mon, 4 Feb 2002, Oliver Feiler wrote:

> Hello,
>
> 	This just changes the printk in the via_northbridge_bug fixup to some
> more meaningful output as it is already in 2.5.3. Please apply.
>
> Oliver
>
> --- linux-2.4.18-pre7/arch/i386/kernel/pci-pc.c	Sun Feb  3 14:56:48 2002
> +++ linux-2.4.18-pre7_testing/arch/i386/kernel/pci-pc.c	Mon Feb  4 11:30:37 2002
> @@ -1129,7 +1129,7 @@
>
>  	pci_read_config_byte(d, where, &v);
>  	if (v & 0xe0) {
> -		printk("Trying to stomp on VIA Northbridge bug...\n");
> +		printk("Disabling broken memory write queue.\n");
>  		v &= 0x1f; /* clear bits 5, 6, 7 */
>  		pci_write_config_byte(d, where, v);
>  	}
>
>
>

Re: fixup descriptions in pci-pc.c

[Denis Vlasenko]

On 3 February 2002 12:29, Oliver Feiler wrote:
> Ok, this is just a cosmetic thing, but I see that in 2.5.3 the printk
> text in pci_fixup_via_northbridge_bug in pci-pc.c was changed
>
> - printk("Trying to stomp on VIA Northbridge bug...\n");
> + printk("Disabling broken memory write queue.\n");
>
> 	Can't we change this to some meaningful output in 2.4.18 as well? It's
> still the old text with pre7.

Probably. + [reg]: old->new or similar
--
vda

Re: fixup descriptions in pci-pc.c

[Denis Vlasenko]

On 4 February 2002 12:49, Oliver Feiler wrote:
> Denis Vlasenko wrote:
> > Probably. + [reg]: old->new or similar
>
> 	Ok. Better with this?
>
>
> --- linux-2.4.18-pre7/arch/i386/kernel/pci-pc.c	Mon Feb  4 15:13:45 2002
> +++ linux-2.4.18-pre7_testing/arch/i386/kernel/pci-pc.c	Mon Feb  4 15:15:13
> 2002 @@ -1129,7 +1129,7 @@
>
>  	pci_read_config_byte(d, where, &v);
>  	if (v & 0xe0) {
> -		printk("Trying to stomp on VIA Northbridge bug...\n");
> +		printk("Disabling VIA memory write queue. Clearing bits 5, 6, 7 at
> 0x%x.\n", where); v &= 0x1f; /* clear bits 5, 6, 7 */
>  		pci_write_config_byte(d, where, v);
>  	}

printk("Disabling VIA memory write queue: [%02x] %02x->%02x\n", where, v, v & 0x1f);

This way we will see exactly where and what changed
--
vda