public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: hch@caldera.de
Cc: davidm@hpl.hp.com, mmadore@turbolinux.com,
	linux-ia64@linuxia64.org, linux-kernel@vger.kernel.org,
	groudier@free.fr
Subject: Re: [Linux-ia64] Proper fix for sym53c8xx_2 driver and dma64_addr_t
Date: Wed, 06 Feb 2002 18:09:15 -0800 (PST)	[thread overview]
Message-ID: <20020206.180915.78161963.davem@redhat.com> (raw)
In-Reply-To: <20020206181042.A11683@caldera.de>
In-Reply-To: <20020206093558.A9445@caldera.de> <20020206.004503.118628125.davem@redhat.com> <20020206181042.A11683@caldera.de>

   From: Christoph Hellwig <hch@caldera.de>
   Date: Wed, 6 Feb 2002 18:10:42 +0100
   
   When the sym2 driver is configured with SYM_CONF_DMA_ADDRESSING_MOD > 1
   it uses DAC accessing and needs dma64_addr_t.  It doesn't use it
   when using the default addressing mode.
   
NO it damn well does not!  If the platform is NEVER GOING TO GIVE the
driver a 64-bit address (because, for example, it has IOMMU hardware),
dma_addr_t need only be 32-bits and that it how it is declared on
several platforms.

Please read the DMA API documentation.

dma64_addr_t is _ONLY_, I REPEAT _ONLY_ to be used when the driver
is making use of the following routines for it's DMA usage:

	pci_dac_page_to_dma
	pci_dac_dma_to_page
	pci_dac_dma_to_offset
	pci_dac_dma_sync_single

And NO SCSI OR NET driver should ever use these routines.

In fact, no driver in the tree right now should be using this.
The only known example that needs those interfaces are clustering
cards.  And thats it!

Everything in the tree right now should use only pci_map_single and
friends, and it should set the device DMA mask bits properly to
indicate DAC capability.  Do you see any pci_map_single, pci_map_sg,
etc. implementation working with dma64_addr_t arguments?  If so, thats
a huge bug and it must be fixed.

  parent reply	other threads:[~2002-02-07  2:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <3C6043E5.D1F40E5D@turbolinux.com>
     [not found] ` <20020205223804.A22012@caldera.de>
     [not found]   ` <15456.21030.840746.209377@napali.hpl.hp.com>
2002-02-06  8:21     ` [Linux-ia64] Proper fix for sym53c8xx_2 driver and dma64_addr_t Christoph Hellwig
2002-02-06  8:29       ` David S. Miller
2002-02-06  8:35         ` Christoph Hellwig
2002-02-06  8:45           ` David S. Miller
2002-02-05 21:23             ` Gérard Roudier
2002-02-06 17:10             ` Christoph Hellwig
2002-02-06 17:15               ` Christoph Hellwig
2002-02-06 17:15               ` David Mosberger
2002-02-05 21:34                 ` Gérard Roudier
2002-02-07  2:09               ` David S. Miller [this message]
2002-02-06 21:38                 ` Gérard Roudier
2002-02-06 16:54       ` David Mosberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020206.180915.78161963.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=davidm@hpl.hp.com \
    --cc=groudier@free.fr \
    --cc=hch@caldera.de \
    --cc=linux-ia64@linuxia64.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmadore@turbolinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox