From: Pavel Machek <pavel@suse.cz>
To: Zwane Mwaikambo <zwane@linux.realnet.co.sz>
Cc: kernel list <linux-kernel@vger.kernel.org>,
Patrick Mochel <mochel@osdl.org>
Subject: Re: driverfs support for motherboard devices
Date: Wed, 6 Feb 2002 13:16:27 +0100 [thread overview]
Message-ID: <20020206121627.GA446@elf.ucw.cz> (raw)
In-Reply-To: <20020205173912.GA165@elf.ucw.cz> <Pine.LNX.4.44.0202060921380.8308-100000@netfinity.realnet.co.sz>
In-Reply-To: <Pine.LNX.4.44.0202060921380.8308-100000@netfinity.realnet.co.sz>
Hi!
> > +static void __init init_8259A_devicefs(void)
> > +{
> > + device_register(&device_i8259A);
> > + strcpy(device_i8259A.name, "i8259A");
> > + strcpy(device_i8259A.bus_id, "0020");
> > + device_i8259A.parent = &sys_iobus;
>
> I'm not entirely familiar with the driverfs API but wouldn't an API
> function to do all that strcpy and other init assignments be a bit
> cleaner? I see lots of retyping going on otherwise, someone feel free to
> hit me with a clue bat if i'm missing something...
I guess that's okay. We do not helper with 1000 arguments to fill
structure up. It will be strcpy sometimes, sprintf
sometimes.... Better leave that alone.
Pavel
--
(about SSSCA) "I don't say this lightly. However, I really think that the U.S.
no longer is classifiable as a democracy, but rather as a plutocracy." --hpa
next prev parent reply other threads:[~2002-02-06 22:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-05 17:39 driverfs support for motherboard devices Pavel Machek
2002-02-05 18:11 ` Xavier Bestel
2002-02-06 7:28 ` Zwane Mwaikambo
2002-02-05 18:36 ` Jeff Garzik
2002-02-05 18:43 ` Patrick Mochel
2002-02-05 20:47 ` Russell King
2002-02-05 22:46 ` Andre Hedrick
2002-02-05 23:06 ` Joel Jaeggli
2002-02-05 23:30 ` Alan Cox
2002-02-05 23:25 ` Patrick Mochel
2002-02-05 23:08 ` Patrick Mochel
2002-02-05 23:17 ` Joel Jaeggli
2002-02-06 12:22 ` Pavel Machek
2002-02-06 23:34 ` Patrick Mochel
2002-02-07 13:03 ` Pavel Machek
2002-02-07 0:38 ` Alan Cox
2002-02-07 12:31 ` Pavel Machek
2002-02-07 13:23 ` Dave Jones
2002-02-07 17:26 ` Patrick Mochel
2002-02-07 17:28 ` Dave Jones
2002-02-07 18:32 ` Gunther Mayer
2002-02-07 23:03 ` Pavel Machek
2002-02-06 7:33 ` Zwane Mwaikambo
2002-02-06 7:24 ` Zwane Mwaikambo
2002-02-06 12:16 ` Pavel Machek [this message]
2002-02-06 20:54 ` Patrick Mochel
2002-02-07 20:21 ` Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2002-02-07 18:18 Thomas Hood
2002-02-07 18:28 ` Patrick Mochel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020206121627.GA446@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
--cc=zwane@linux.realnet.co.sz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox