Patch for eepro100 to support more cards

Patch for eepro100 to support more cards

[Hanno Böck]

This patch adds support for the
Intel Pro/100 VE
Network card to the eepro100.c

This card is installed in my notebook (Sony Vaio PCG-GR114MK). Seems to work 
fine.

Patch is for Kernel 2.4.17

--- linux/drivers/net/eepro100.c        Fri Dec 21 18:41:54 2001
+++ linux-2.4.17-patch/drivers/net/eepro100.c   Thu Jan 31 15:51:50 2002
@@ -168,6 +168,9 @@
 #ifndef PCI_DEVICE_ID_INTEL_ID1030
 #define PCI_DEVICE_ID_INTEL_ID1030 0x1030
 #endif
+#ifndef PCI_DEVICE_ID_INTEL_ID1031              // Support for Intel Pro/100 
VE added by Hanno Boeck <hanno@gmx.de>
+#define PCI_DEVICE_ID_INTEL_ID1031 0x1031
+#endif


 static int speedo_debug = 1;
@@ -2270,6 +2273,8 @@
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ID1029,
                PCI_ANY_ID, PCI_ANY_ID, },
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ID1030,
+               PCI_ANY_ID, PCI_ANY_ID, },
+       { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ID1031,         // Support 
for 
Intel Pro/100 VE added by Hanno Boeck <hanno@gmx.de>
                PCI_ANY_ID, PCI_ANY_ID, },
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801BA_7,
                PCI_ANY_ID, PCI_ANY_ID, },

Re: Patch for eepro100 to support more cards

[David Weinehall]

On Fri, Feb 01, 2002 at 09:06:26AM +0100, Hanno Böck wrote:
> This patch adds support for the
> Intel Pro/100 VE
> Network card to the eepro100.c
> 
> This card is installed in my notebook (Sony Vaio PCG-GR114MK). Seems to work 
> fine.

Nice!

[snip]

> +#ifndef PCI_DEVICE_ID_INTEL_ID1031	// Support for Intel Pro/100 
> VE added by Hanno Boeck <hanno@gmx.de>

[snip]

PLEASE put this kind of comments in the changelog or similarly fitting
place instead of in the code. If everyone had their e-mail address
in a comment after every line they added, would be bloated beyond
proportions (some argue that it already is, but let's ignore that for
now...)


Regards: David Weinehall
  _                                                                 _
 // David Weinehall <tao@acc.umu.se> /> Northern lights wander      \\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\>  http://www.acc.umu.se/~tao/    </   Full colour fire           </

Re: Patch for eepro100 to support more cards

[Hanno Böck]

Because of some complains and as pre8 is out now, I made it again for the 2.4.18pre8-kernel.
I hope it is okay now.

I put up a site for the patch: http://www.int21.de/eepro100/

The Patch adds definitions for the Intel Pro/100 VE-card to the eepro100-driver.

--- linux-2.4.18-pre8/drivers/net/eepro100.c	Wed Feb  6 15:15:16 2002
+++ linux/drivers/net/eepro100.c	Wed Feb  6 15:19:14 2002
@@ -168,6 +168,9 @@
 #ifndef PCI_DEVICE_ID_INTEL_ID1030
 #define PCI_DEVICE_ID_INTEL_ID1030 0x1030
 #endif
+#ifndef PCI_DEVICE_ID_INTEL_ID1031          /* support for Intel Pro/100 VE */
+#define PCI_DEVICE_ID_INTEL_ID1031 0x1031
+#endif


 static int speedo_debug = 1;
@@ -2270,6 +2273,8 @@
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ID1029,
 		PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ID1030,
+		PCI_ANY_ID, PCI_ANY_ID, },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ID1031,     /* support for Intel Pro/100 VE */
 		PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801BA_7,
 		PCI_ANY_ID, PCI_ANY_ID, },

Re: Patch for eepro100 to support more cards

[Josh Grebe]

Hanno,

Patches that I had previously sent to add support for other cards were not 
accepted when I had it done like this. The fix was to ad an entry for the PCI 
ID into include/linux/pci_ids.h instead of adding defines into eepro100.c.
You might try changing that and resubmitting, it is a cleaner way to do it 
anyway.

Josh


On Wednesday 06 February 2002 08:45, Hanno Böck wrote:
> Because of some complains and as pre8 is out now, I made it again for the
> 2.4.18pre8-kernel. I hope it is okay now.
>
> I put up a site for the patch: http://www.int21.de/eepro100/
>
> The Patch adds definitions for the Intel Pro/100 VE-card to the
> eepro100-driver.
>
> --- linux-2.4.18-pre8/drivers/net/eepro100.c	Wed Feb  6 15:15:16 2002
> +++ linux/drivers/net/eepro100.c	Wed Feb  6 15:19:14 2002
> @@ -168,6 +168,9 @@
>  #ifndef PCI_DEVICE_ID_INTEL_ID1030
>  #define PCI_DEVICE_ID_INTEL_ID1030 0x1030
>  #endif
> +#ifndef PCI_DEVICE_ID_INTEL_ID1031          /* support for Intel Pro/100
> VE */ +#define PCI_DEVICE_ID_INTEL_ID1031 0x1031
> +#endif
>
>
>  static int speedo_debug = 1;
> @@ -2270,6 +2273,8 @@
>  	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ID1029,
>  		PCI_ANY_ID, PCI_ANY_ID, },
>  	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ID1030,
> +		PCI_ANY_ID, PCI_ANY_ID, },
> +	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ID1031,     /* support for
> Intel Pro/100 VE */ PCI_ANY_ID, PCI_ANY_ID, },
>  	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801BA_7,
>  		PCI_ANY_ID, PCI_ANY_ID, },
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/