From: Vojtech Pavlik <vojtech@suse.cz>
To: Bill Davidsen <davidsen@tmr.com>
Cc: Pavel Machek <pavel@suse.cz>, Dave Jones <davej@suse.de>,
kernel list <linux-kernel@vger.kernel.org>,
vojtech@ucw.cz, andre@linuxdiskcert.org
Subject: Re: ide cleanup
Date: Sat, 9 Feb 2002 19:35:00 +0100 [thread overview]
Message-ID: <20020209193500.A18944@suse.cz> (raw)
In-Reply-To: <20020206205332.GA3217@elf.ucw.cz> <Pine.LNX.3.96.1020209131726.23246D-100000@gatekeeper.tmr.com>
In-Reply-To: <Pine.LNX.3.96.1020209131726.23246D-100000@gatekeeper.tmr.com>; from davidsen@tmr.com on Sat, Feb 09, 2002 at 01:19:58PM -0500
On Sat, Feb 09, 2002 at 01:19:58PM -0500, Bill Davidsen wrote:
> On Wed, 6 Feb 2002, Pavel Machek wrote:
>
> > -#ifdef CONFIG_BLK_DEV_PDC4030
> > if (IS_PDC4030_DRIVE) {
> > extern ide_startstop_t promise_rw_disk(ide_drive_t *, struct request *, unsigned long);
> > return promise_rw_disk(drive, rq, block);
> > }
> > -#endif /* CONFIG_BLK_DEV_PDC4030 */
>
> Am I reading this totally wrong, or do you really think it's a good idea
> to test for a drive even if the user didn't configure such hardware?
Well, since IS_PDC4030_DRIVE will always be 0 in that case, the test
will be optimized out ...
--
Vojtech Pavlik
SuSE Labs
next prev parent reply other threads:[~2002-02-09 18:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-06 20:53 ide cleanup Pavel Machek
2002-02-07 3:34 ` Andre Hedrick
2002-02-07 7:29 ` Vojtech Pavlik
2002-02-07 12:40 ` Pavel Machek
2002-02-08 12:34 ` Martin Dalecki
2002-02-08 12:37 ` Vojtech Pavlik
2002-02-08 13:15 ` Martin Dalecki
2002-02-08 14:50 ` Wichert Akkerman
2002-02-08 15:08 ` Dave Jones
2002-02-08 15:09 ` Wichert Akkerman
2002-02-08 15:08 ` Martin Dalecki
2002-02-08 23:00 ` James Antill
2002-02-08 22:10 ` Pavel Machek
2002-02-09 18:19 ` Bill Davidsen
2002-02-09 18:35 ` Vojtech Pavlik [this message]
2002-02-11 19:15 ` Bill Davidsen
2002-02-12 10:00 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020209193500.A18944@suse.cz \
--to=vojtech@suse.cz \
--cc=andre@linuxdiskcert.org \
--cc=davej@suse.de \
--cc=davidsen@tmr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=vojtech@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox