From: "René Scharfe" <l.s.r@web.de>
To: "Alex Scheele" <alex@packetstorm.nu>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [patch][2.5.4-dj4] cleanup to use strsep for fs/fat/inode.c
Date: Sun, 10 Feb 2002 14:19:18 +0100 [thread overview]
Message-ID: <20020210141918.3552d0fc.l.s.r@web.de> (raw)
Hi,
> This patch changes all use of strtok() to strsep().
> Strtok() isn't SMP/thread safe. strsep is considered safer.
OK, but ...
> - for (this_char = strtok(options,","); this_char;
> - this_char = strtok(NULL,",")) {
This _does not_ change the value of 'options'.
> + while ((this_char = strsep(&options,",")) != NULL) {
This _does_ change the value of 'options'. Problem is, it's
used later. Same is true for your patch to fs/vfat/namei.c.
René
next reply other threads:[~2002-02-10 13:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-10 13:19 René Scharfe [this message]
2002-02-10 14:27 ` [patch][2.5.4-dj4] cleanup to use strsep for fs/fat/inode.c Alex Scheele
-- strict thread matches above, loose matches on Subject: below --
2002-02-10 1:48 Alex Scheele
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020210141918.3552d0fc.l.s.r@web.de \
--to=l.s.r@web.de \
--cc=alex@packetstorm.nu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox