* [PATCH] Linux-2.5.4-pre6 uhci.c compile fix
@ 2002-02-11 2:37 Udo A. Steinberg
2002-02-11 3:11 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Udo A. Steinberg @ 2002-02-11 2:37 UTC (permalink / raw)
To: Linus Torvalds, Linux Kernel, greg
Hi Linus, Greg,
The attached patch fixes a trivial compiler warning in uhci.c:
uhci.c: In function `uhci_unlink_generic':
uhci.c:1694: warning: suggest parentheses around && within ||
Regards,
Udo.
diff -X dontdiff -Naur linux-2.5.4-pre-vanilla/drivers/usb/uhci.c linux-2.5.4-pre/drivers/usb/uhci.c
--- linux-2.5.4-pre-vanilla/drivers/usb/uhci.c Mon Feb 11 03:04:17 2002
+++ linux-2.5.4-pre/drivers/usb/uhci.c Mon Feb 11 03:11:47 2002
@@ -1689,8 +1689,8 @@
/* Control and Isochronous ignore the toggle, so this */
/* is safe for all types */
- if ((!(td->status & TD_CTRL_ACTIVE) &&
- (uhci_actual_length(td->status) < uhci_expected_length(td->info)) ||
+ if (((!(td->status & TD_CTRL_ACTIVE) &&
+ (uhci_actual_length(td->status) < uhci_expected_length(td->info))) ||
tmp == head)) {
usb_settoggle(urb->dev, uhci_endpoint(td->info),
uhci_packetout(td->info),
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Linux-2.5.4-pre6 uhci.c compile fix
2002-02-11 2:37 [PATCH] Linux-2.5.4-pre6 uhci.c compile fix Udo A. Steinberg
@ 2002-02-11 3:11 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2002-02-11 3:11 UTC (permalink / raw)
To: Udo A. Steinberg; +Cc: Linus Torvalds, Linux Kernel
On Mon, Feb 11, 2002 at 03:37:22AM +0100, Udo A. Steinberg wrote:
>
> Hi Linus, Greg,
>
> The attached patch fixes a trivial compiler warning in uhci.c:
I've asked Johannes about this warning, and he said he'd fix it, so I'd
prefer you to send your patch to him first.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-02-11 3:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-02-11 2:37 [PATCH] Linux-2.5.4-pre6 uhci.c compile fix Udo A. Steinberg
2002-02-11 3:11 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox