The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Pete Zaitcev <zaitcev@redhat.com>
To: zwane@linux.realnet.co.sz
Cc: Kernel Janitors <kernel-janitor-discuss@lists.sourceforge.net>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] printk prefix cleanups.
Date: Tue, 12 Feb 2002 02:18:47 -0500	[thread overview]
Message-ID: <200202120718.g1C7IlS29064@devserv.devel.redhat.com> (raw)
In-Reply-To: <mailman.1013495822.30629.linux-kernel2news@redhat.com>
In-Reply-To: <mailman.1013495822.30629.linux-kernel2news@redhat.com>

> Here is a simple patch which reduces resultant binary size by 1.2k for 
> this particular module (opl3sa2). [...]

>  #define OPL3SA2_MODULE_NAME	"opl3sa2"
> +#define OPL3SA2_PFX		OPL3SA2_MODULE_NAME ": "
 
> -			printk(KERN_ERR "opl3sa2: MSS mixer not installed?\n");
> +			printk(KERN_ERR OPL3SA2_PFX "MSS mixer not installed?\n");

I do not believe that it shortens binaries. Care to quote
size(1) output and /proc/modules with and without the patch?

-- Pete

       reply	other threads:[~2002-02-12  7:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.1013495822.30629.linux-kernel2news@redhat.com>
2002-02-12  7:18 ` Pete Zaitcev [this message]
2002-02-12  7:26   ` [PATCH] printk prefix cleanups Zwane Mwaikambo
2002-02-12  7:37     ` Jeff Garzik
2002-02-12  7:46       ` Zwane Mwaikambo
2002-02-12  6:26 Zwane Mwaikambo
2002-02-12  6:46 ` Jeff Garzik
2002-02-12  9:50 ` Horst von Brand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200202120718.g1C7IlS29064@devserv.devel.redhat.com \
    --to=zaitcev@redhat.com \
    --cc=kernel-janitor-discuss@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zwane@linux.realnet.co.sz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox