From: Jens Axboe <axboe@suse.de>
To: reddog83 <reddog83@chartermi.net>
Cc: Paul Fulghum <paulkf@microgate.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.3-dj5 synclink.c fix so that it compiles
Date: Tue, 12 Feb 2002 07:56:36 +0100 [thread overview]
Message-ID: <20020212075636.T729@suse.de> (raw)
In-Reply-To: <auto-000058815980@front2.chartermi.net> <001701c1b312$24448ca0$0c00a8c0@diemos> <auto-000058467594@front1.chartermi.net>
In-Reply-To: <auto-000058467594@front1.chartermi.net>
On Mon, Feb 11 2002, reddog83 wrote:
> Paul-
> That is understandable. I had the same guess as you when I made this patch.
> Why is ths synclink.c driver using DMA Mapping. After I took that line out I
> was fine becuase my system is fine.
The "real" fix for synclink is just something like this, afaics.
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.275 -> 1.276
# drivers/char/synclink.c 1.11 -> 1.12
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 02/02/12 axboe@burns.home.kernel.dk 1.276
# synclink is an ISA-only driver, so just use isa_virt_to_bus to make
# it work
# --------------------------------------------
#
diff -Nru a/drivers/char/synclink.c b/drivers/char/synclink.c
--- a/drivers/char/synclink.c Tue Feb 12 07:55:54 2002
+++ b/drivers/char/synclink.c Tue Feb 12 07:55:54 2002
@@ -60,8 +60,6 @@
# define BREAKPOINT() { }
#endif
-#error Please convert me to Documentation/DMA-mapping.txt
-
#define MAX_ISA_DEVICES 10
#define MAX_PCI_DEVICES 10
#define MAX_TOTAL_DEVICES 20
@@ -3985,7 +3983,7 @@
if ( info->buffer_list == NULL )
return -ENOMEM;
- info->buffer_list_phys = virt_to_bus(info->buffer_list);
+ info->buffer_list_phys = isa_virt_to_bus(info->buffer_list);
}
/* We got the memory for the buffer entry lists. */
@@ -4096,7 +4094,7 @@
kmalloc(DMABUFFERSIZE, GFP_KERNEL | GFP_DMA);
if ( BufferList[i].virt_addr == NULL )
return -ENOMEM;
- phys_addr = virt_to_bus(BufferList[i].virt_addr);
+ phys_addr = isa_virt_to_bus(BufferList[i].virt_addr);
}
BufferList[i].phys_addr = phys_addr;
}
--
Jens Axboe
next prev parent reply other threads:[~2002-02-12 6:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-11 5:12 [PATCH] 2.5.3-dj5 synclink.c fix so that it compiles reddog83
2002-02-11 9:49 ` Jens Axboe
2002-02-11 15:38 ` Paul Fulghum
2002-02-11 20:48 ` reddog83
2002-02-12 6:56 ` Jens Axboe [this message]
2002-02-12 7:03 ` Jens Axboe
2002-02-12 7:07 ` Jens Axboe
2002-02-12 7:11 ` David S. Miller
2002-02-12 7:14 ` Jens Axboe
2002-02-12 14:24 ` Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020212075636.T729@suse.de \
--to=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=paulkf@microgate.com \
--cc=reddog83@chartermi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox