From: Vojtech Pavlik <vojtech@suse.cz>
To: Rob Radez <rob@osinvestor.com>
Cc: Pavel Machek <pavel@suse.cz>, kernel list <linux-kernel@vger.kernel.org>
Subject: Re: small IDE cleanup: void * should not be used unless neccessary
Date: Wed, 13 Feb 2002 08:29:25 +0100 [thread overview]
Message-ID: <20020213082925.B30588@suse.cz> (raw)
In-Reply-To: <20020211220937.GA121@elf.ucw.cz> <Pine.LNX.4.33.0202121758260.26027-100000@pita.lan>
In-Reply-To: <Pine.LNX.4.33.0202121758260.26027-100000@pita.lan>; from rob@osinvestor.com on Tue, Feb 12, 2002 at 06:02:16PM -0500
On Tue, Feb 12, 2002 at 06:02:16PM -0500, Rob Radez wrote:
>
> On Mon, 11 Feb 2002, Pavel Machek wrote:
>
> > Hi!
> >
> > This is really easy, please apply. (It will allow me to kill few casts
> > in future).
> > Pavel
> >
> > --- linux/include/linux/ide.h Mon Feb 11 21:15:04 2002
> > +++ linux-dm/include/linux/ide.h Mon Feb 11 22:36:12 2002
> > @@ -529,7 +531,7 @@
> >
> > typedef struct hwif_s {
> > struct hwif_s *next; /* for linked-list in ide_hwgroup_t */
> > - void *hwgroup; /* actually (ide_hwgroup_t *) */
> > + struct hwgroup_s *hwgroup; /* actually (ide_hwgroup_t *) */
> > ide_ioreg_t io_ports[IDE_NR_PORTS]; /* task file registers */
> > hw_regs_t hw; /* Hardware info */
> > ide_drive_t drives[MAX_DRIVES]; /* drive info */
>
> If you're doing this, would it make sense to get rid of the useless casting
> of the hwgroup member?
Yes, that's also planned.
--
Vojtech Pavlik
SuSE Labs
next prev parent reply other threads:[~2002-02-13 7:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-11 22:09 small IDE cleanup: void * should not be used unless neccessary Pavel Machek
2002-02-12 22:50 ` Rob Landley
2002-02-12 22:57 ` Rob Radez
2002-02-13 10:47 ` Pavel Machek
2002-02-13 19:39 ` Rob Landley
2002-02-13 22:50 ` Pavel Machek
2002-02-16 1:08 ` Andre Hedrick
2002-02-16 8:07 ` Vojtech Pavlik
2002-02-12 23:02 ` Rob Radez
2002-02-13 7:29 ` Vojtech Pavlik [this message]
2002-02-13 10:46 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020213082925.B30588@suse.cz \
--to=vojtech@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=rob@osinvestor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox