From: Gerd Knorr <kraxel@bytesex.org>
To: Linus Torvalds <torvalds@transmeta.com>,
Kernel List <linux-kernel@vger.kernel.org>
Subject: [PATCH] es1370 fix
Date: Thu, 14 Feb 2002 16:17:30 +0100 [thread overview]
Message-ID: <20020214161730.A8112@bytesex.org> (raw)
Hi,
This patch fixes the es1370 driver (the virt_to_bus thing).
Gerd
----------------------------- cut here --------------------------
--- linux-2.5.5-pre1/sound/oss/es1370.c Thu Feb 14 15:57:34 2002
+++ linux/sound/oss/es1370.c Thu Feb 14 16:03:43 2002
@@ -374,6 +374,10 @@
unsigned subdivision;
} dma_dac1, dma_dac2, dma_adc;
+ /* The following buffer is used to point the phantom write channel to. */
+ unsigned char *bugbuf_cpu;
+ dma_addr_t bugbuf_dma;
+
/* midi stuff */
struct {
unsigned ird, iwr, icnt;
@@ -392,13 +396,6 @@
static LIST_HEAD(devs);
-/*
- * The following buffer is used to point the phantom write channel to,
- * so that it cannot wreak havoc. The attribute makes sure it doesn't
- * cross a page boundary and ensures dword alignment for the DMA engine
- */
-static unsigned char bugbuf[16] __attribute__ ((aligned (16)));
-
/* --------------------------------------------------------------------- */
static inline unsigned ld2(unsigned int x)
@@ -2653,8 +2650,9 @@
outl(s->ctrl, s->io+ES1370_REG_CONTROL);
outl(s->sctrl, s->io+ES1370_REG_SERIAL_CONTROL);
/* point phantom write channel to "bugbuf" */
+ s->bugbuf_cpu = pci_alloc_consistent(pcidev,16,&s->bugbuf_dma);
outl((ES1370_REG_PHANTOM_FRAMEADR >> 8) & 15, s->io+ES1370_REG_MEMPAGE);
- outl(virt_to_bus(bugbuf), s->io+(ES1370_REG_PHANTOM_FRAMEADR & 0xff));
+ outl(s->bugbuf_dma, s->io+(ES1370_REG_PHANTOM_FRAMEADR & 0xff));
outl(0, s->io+(ES1370_REG_PHANTOM_FRAMECNT & 0xff));
pci_set_master(pcidev); /* enable bus mastering */
wrcodec(s, 0x16, 3); /* no RST, PD */
@@ -2721,6 +2719,7 @@
unregister_sound_mixer(s->dev_mixer);
unregister_sound_dsp(s->dev_dac);
unregister_sound_midi(s->dev_midi);
+ pci_free_consistent(dev, 16, s->bugbuf_cpu, s->bugbuf_dma);
kfree(s);
pci_set_drvdata(dev, NULL);
}
next reply other threads:[~2002-02-14 16:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-14 15:17 Gerd Knorr [this message]
2002-02-14 17:27 ` [PATCH] es1370 fix Thomas Sailer
2002-02-16 9:31 ` [PATCH] 2.4.18-rc1 " Pierre Rousselet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020214161730.A8112@bytesex.org \
--to=kraxel@bytesex.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox