From: Vojtech Pavlik <vojtech@suse.cz>
To: Andre Hedrick <andre@linuxdiskcert.org>
Cc: Pavel Machek <pavel@suse.cz>, Rob Landley <landley@trommello.org>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: small IDE cleanup: void * should not be used unless neccessary
Date: Sat, 16 Feb 2002 09:07:15 +0100 [thread overview]
Message-ID: <20020216090715.A8948@suse.cz> (raw)
In-Reply-To: <20020213225047.GI1454@elf.ucw.cz> <Pine.LNX.4.10.10202151707440.10501-100000@master.linux-ide.org>
In-Reply-To: <Pine.LNX.4.10.10202151707440.10501-100000@master.linux-ide.org>; from andre@linuxdiskcert.org on Fri, Feb 15, 2002 at 05:08:20PM -0800
On Fri, Feb 15, 2002 at 05:08:20PM -0800, Andre Hedrick wrote:
> > > I know they're functionally equivalent, but so was the original void
> > > *. :)
> >
> > Well, void * hides real errors.
> >
> > > Just an "as long as you're touching this line anyway, why leave the old
> > > comment?" thing. A minor, in-passing nit at best...
> >
> > ide_hwgroup_t is used in 90% of rest of code, so I thought I better
> > leave it there.
>
> So what do we do with the other 10% break it? Sheesh :-/
The other 10% won't break by the change, of course.
--
Vojtech Pavlik
SuSE Labs
next prev parent reply other threads:[~2002-02-16 8:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-11 22:09 small IDE cleanup: void * should not be used unless neccessary Pavel Machek
2002-02-12 22:50 ` Rob Landley
2002-02-12 22:57 ` Rob Radez
2002-02-13 10:47 ` Pavel Machek
2002-02-13 19:39 ` Rob Landley
2002-02-13 22:50 ` Pavel Machek
2002-02-16 1:08 ` Andre Hedrick
2002-02-16 8:07 ` Vojtech Pavlik [this message]
2002-02-12 23:02 ` Rob Radez
2002-02-13 7:29 ` Vojtech Pavlik
2002-02-13 10:46 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020216090715.A8948@suse.cz \
--to=vojtech@suse.cz \
--cc=andre@linuxdiskcert.org \
--cc=landley@trommello.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox