From: Pete Zaitcev <zaitcev@redhat.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: ENOTTY from ext3 code?
Date: Tue, 19 Feb 2002 16:53:26 -0500 [thread overview]
Message-ID: <200202192153.g1JLrQH05684@devserv.devel.redhat.com> (raw)
In-Reply-To: <mailman.1014150283.20067.linux-kernel2news@redhat.com>
In-Reply-To: <mailman.1014150283.20067.linux-kernel2news@redhat.com>
> ext3/ioctl.c:
> ...
> return -ENOTTY;
>
> Does it really make sense to return "not a typewriter" from ext3
> ioctl?
Absolutely. In fact, it's a pet pieve of mine. Lots and lots
of clueless driver writes return -EINVAL in such cases,
and I keep cleaning it up. The problem with EINVAL is that
it makes it harder to diagnose any problems that can come up.
Also, recent strerror() returns "Inappropriate ioctl for a device",
if that is your concern. Personally, I think "Not a typewriter"
was a warmer and fuzzier reference to the roots, but oh well...
Dennis giveth, TOG taketh away...
-- Pete
next parent reply other threads:[~2002-02-19 21:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.1014150283.20067.linux-kernel2news@redhat.com>
2002-02-19 21:53 ` Pete Zaitcev [this message]
2002-02-20 1:23 ` ENOTTY from ext3 code? Alan Cox
2002-02-19 19:09 Pavel Machek
2002-02-19 20:31 ` Alexander Viro
2002-02-19 20:34 ` Richard B. Johnson
2002-02-19 20:56 ` Andrew Morton
2002-02-19 21:20 ` Andreas Dilger
2002-02-19 21:26 ` Guest section DW
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200202192153.g1JLrQH05684@devserv.devel.redhat.com \
--to=zaitcev@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox