From: Christoph Pittracher <pitt@gmx.at>
To: Jean Paul Sartre <sartre@linuxbr.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: sis_malloc / sis_free
Date: Wed, 20 Feb 2002 02:47:48 +0100 [thread overview]
Message-ID: <200202200237.28577@pitt4u.2y.net> (raw)
In-Reply-To: <Pine.LNX.4.40.0202192220550.13176-100000@sartre.linuxbr.com>
In-Reply-To: <Pine.LNX.4.40.0202192220550.13176-100000@sartre.linuxbr.com>
Hello!
On Wednesday 20 February 2002 02:26, Jean Paul Sartre wrote:
> I was grepping through the SIS malloc/free code and I saw DRM
> 'shares' code with the fb code. What if I have SIS framebuffer
> disabled and SIS DRM code enabled? In 2.4.18-rc2, the SIS DRM code
> does not compile from the lack of sis_malloc and sis_free function.
Yes, the sisfb/drm code has some design lacks.
Another lack is the necessary memory offset between framebuffer/drm and
the X driver (see http://www.webit.at/~twinny/linuxsis630.shtml for
details).
> I would suggest 'duplicating' this code (yes, I *do* hate
> duplicating codes) or making that memory allocation code *really*
> shared between both modules (or we won't be able to successfully
> compile it, since the DRM code is on drivers/char/drm and the FB code
> is on drivers/video/sis/sis_main.c).
I don't think that it would be a problem to duplicate the code. the
sis_malloc / sis_free functions seems quite stable. I don't think that
there will be big updates for this code.
> If the suggestion of 'duplicating' code (argh) is reasonable
> enough (for they are really different codes) I can work and submit a
> patch.
Thomas Winischhofer <tw@webit.com> is working on that SiS stuff for
about 2 months. I think it would be best if you contact him and ask
what he thinks about that. I know that he said it would be a good idea
to seperate the sisfb and sis_drm code but he doesn't have enough time
to do it...
regards,
Christoph
next prev parent reply other threads:[~2002-02-20 1:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-20 1:26 sis_malloc / sis_free Jean Paul Sartre
2002-02-20 1:47 ` Christoph Pittracher [this message]
2002-02-20 2:17 ` Jean Paul Sartre
2002-02-20 1:51 ` Alan Cox
2002-02-20 1:40 ` Jean Paul Sartre
2002-02-20 2:14 ` Alan Cox
2002-02-20 2:11 ` Jean Paul Sartre
2002-02-20 2:28 ` Alan Cox
2002-02-20 1:45 ` Jean Paul Sartre
2002-02-20 16:43 ` James Simmons
2002-02-20 17:08 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2002-02-20 18:25 Thomas Winischhofer
2002-02-20 19:20 ` Jean Paul Sartre
2002-02-20 20:49 ` Thomas Winischhofer
2002-02-20 22:31 ` Cesar Suga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200202200237.28577@pitt4u.2y.net \
--to=pitt@gmx.at \
--cc=linux-kernel@vger.kernel.org \
--cc=sartre@linuxbr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox