* Tiny IDE cleanup
@ 2002-02-19 19:41 Pavel Machek
2002-02-20 10:27 ` Martin Dalecki
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Machek @ 2002-02-19 19:41 UTC (permalink / raw)
To: trivial; +Cc: kernel list
Hi!
What about this tiny cleanup? Its against 2.4., but applicable to 2.5,
too.
Pavel
--- clean.2.4/include/linux/ide.h Mon Nov 5 21:43:28 2001
+++ linux-swsusp.24/include/linux/ide.h Tue Feb 19 20:38:38 2002
@@ -697,11 +698,9 @@
* structure directly (the allocation/layout may change!).
*
*/
-#ifndef _IDE_C
extern ide_hwif_t ide_hwifs[]; /* master data repository */
extern ide_module_t *ide_modules;
extern ide_module_t *ide_probe;
-#endif
extern int noautodma;
/*
@@ -900,10 +899,8 @@
void do_ide_request (request_queue_t * q);
void ide_init_subdrivers (void);
-#ifndef _IDE_C
extern struct block_device_operations ide_fops[];
extern ide_proc_entry_t generic_subdriver_entries[];
-#endif
#ifdef _IDE_C
#ifdef CONFIG_BLK_DEV_IDE
--
(about SSSCA) "I don't say this lightly. However, I really think that the U.S.
no longer is classifiable as a democracy, but rather as a plutocracy." --hpa
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Tiny IDE cleanup
2002-02-19 19:41 Tiny IDE cleanup Pavel Machek
@ 2002-02-20 10:27 ` Martin Dalecki
2002-02-20 10:29 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Martin Dalecki @ 2002-02-20 10:27 UTC (permalink / raw)
To: Pavel Machek; +Cc: trivial, kernel list
Pavel Machek wrote:
> Hi!
>
> What about this tiny cleanup? Its against 2.4., but applicable to 2.5,
> too.
>
That's file.
If you dare to have a look at the LOCAL_END_REQUEST macro
as well? It's only used by IDE and NBD code.
I think that from IDE it can be just deleted. But I didn't
look at NBD.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Tiny IDE cleanup
2002-02-20 10:27 ` Martin Dalecki
@ 2002-02-20 10:29 ` Jens Axboe
0 siblings, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2002-02-20 10:29 UTC (permalink / raw)
To: Martin Dalecki; +Cc: Pavel Machek, trivial, kernel list
On Wed, Feb 20 2002, Martin Dalecki wrote:
> Pavel Machek wrote:
> >Hi!
> >
> >What about this tiny cleanup? Its against 2.4., but applicable to 2.5,
> >too.
> >
>
> That's file.
>
> If you dare to have a look at the LOCAL_END_REQUEST macro
> as well? It's only used by IDE and NBD code.
> I think that from IDE it can be just deleted. But I didn't
> look at NBD.
LOCAL_END_REQUEST is safe to kill, please go ahead.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-02-20 10:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-02-19 19:41 Tiny IDE cleanup Pavel Machek
2002-02-20 10:27 ` Martin Dalecki
2002-02-20 10:29 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox