public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin LaHaise <bcrl@redhat.com>
To: Daniel Phillips <phillips@bonn-fries.net>
Cc: Andries.Brouwer@cwi.nl, torvalds@transmeta.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] size-in-bytes
Date: Thu, 21 Feb 2002 02:04:49 -0500	[thread overview]
Message-ID: <20020221020449.B8733@redhat.com> (raw)
In-Reply-To: <UTC200202161609.QAA31164.aeb@cwi.nl> <E16cwVW-0000jf-00@starship.berlin>
In-Reply-To: <E16cwVW-0000jf-00@starship.berlin>; from phillips@bonn-fries.net on Mon, Feb 18, 2002 at 11:43:38PM +0100

On Mon, Feb 18, 2002 at 11:43:38PM +0100, Daniel Phillips wrote:
> We want to stay with the shift counts.  They should be the primary currency
> of size measurement.  You can add shift counts together and get nice, compact
> code, whereas with absolute size you often have to ugly things - e.g., it's a
> pain to divide by blocksize when you have it as an absolute number, it's easy
> when you have it as a shift.
> 
> If you are going to the trouble of fixing this, please don't use absolute
> size as the primary measure, use a shift count.

Most of this is targetted at userland which needs byte counts (size in 
sectors was a bug introduced after the original BLKGETSIZE64 went in).  
Using the number of sectors in kernel is perhaps more efficient, but it 
is a microoptimization that won't show up on any benchmarks.

		-ben

  reply	other threads:[~2002-02-21  7:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-16 16:09 [PATCH] size-in-bytes Andries.Brouwer
2002-02-16 21:09 ` Martin Dalecki
2002-02-18 22:43 ` Daniel Phillips
2002-02-21  7:04   ` Benjamin LaHaise [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-02-16 21:41 Andries.Brouwer
2002-02-16 22:05 ` Martin Dalecki
2002-02-16 22:45 Andries.Brouwer
2002-02-16 23:10 ` Martin Dalecki
2002-02-18 23:29 Andries.Brouwer
2002-02-18 23:38 ` Daniel Phillips
2002-02-21  9:54 Andries.Brouwer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020221020449.B8733@redhat.com \
    --to=bcrl@redhat.com \
    --cc=Andries.Brouwer@cwi.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phillips@bonn-fries.net \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox