Re: Flash Back -- kernel 2.1.111

Vojtech Pavlik
2002-02-24T22:51:32Z

On Sun, Feb 24, 2002 at 02:44:23PM -0800, David S. Miller wrote:

> From: Vojtech Pavlik <vojtech@suse.cz>
> Date: Sun, 24 Feb 2002 23:39:37 +0100
>
> > > happens if you plug in a 66MHz non-capable card to the 50 MHz bus.
> >
> > The bus speed drops to 33MHz.
>
> Interesting. I'd expect 25 myself ... then we'll definitely need two
> clock values in struct pci_bus - because the hi-speed one isn't always a
> double the low one - as shown by your example.
>
> You only need one, the current active one.
>
> If you think that hot-plug is an issue, the arch dependant could would
> need to recalculate the "current bus speed" and all would be fine.
>
> So why do we need two values?

Oh, you're right. We indeed need only one.

Hmm, now hotplug changing the PCI clock would be quite a lot of fun -
all running drivers will need to know about the change, because some may
need to recompute the timings they have programmed into the chips ...

Because virtually disconnecting and reconnecting all the cards for which
the timings have changed will probably not be an option.

--
Vojtech Pavlik
SuSE Labs