Re: [PATCH] sym53c416 driver breakage

Re: [PATCH] sym53c416 driver breakage

[Jens Axboe]

On Fri, Feb 22 2002, Paulo Andre' wrote:
> Hi,
> 
> The following patch fixes a small bug which prevented the Sym53c416 
> driver from compiling. I don't know to which degree this is the right 
> fix, since the 'address' field from struct scatterlist just seemed to 
> magically disappear. If this was intended, meaning my fix isn't 
> correct, I'd like to know about it.

This is very wrong, we removed ->address for a reason (unify handling of
lo+hi memory suppot). So it may fix you compile, but that's all it will
fix. IOW, it won't work.

-- 
Jens Axboe

[PATCH] sym53c416 driver breakage

[Paulo Andre']

Hi,

The following patch fixes a small bug which prevented the Sym53c416 
driver from compiling. I don't know to which degree this is the right 
fix, since the 'address' field from struct scatterlist just seemed to 
magically disappear. If this was intended, meaning my fix isn't 
correct, I'd like to know about it.


--- linux-2.5.5-dj1/include/asm-i386/scatterlist.h      Fri Feb 22 
15:32:59 2002
+++ linux-dev/include/asm-i386/scatterlist.h    Fri Feb 22 15:29:32 2002
@@ -2,6 +2,7 @@
  #define _I386_SCATTERLIST_H
   struct scatterlist {
+    char               *address;            struct page                
*page;
      unsigned int       offset;
      dma_addr_t         dma_address;



Thanks in advance,

// Paulo Andre'




  /~\ The ASCII
  \ / Ribbon Campaign
   X  Against HTML
  / \ Email!

Re: [PATCH] sym53c416 driver breakage

[Paulo Andre']

On 2002.02.22 15:52 Jens Axboe wrote:
> This is very wrong, we removed ->address for a reason (unify handling
> of
> lo+hi memory suppot). So it may fix you compile, but that's all it
> will
> fix. IOW, it won't work.

Thanks, Jens. I was wondering about it, not anymore. I'll just let the 
gurus work it out :)

// Paulo Andre'