From: Benjamin LaHaise <bcrl@redhat.com>
To: Balbir Singh <balbir_soni@hotmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Trivial patch against mempool
Date: Fri, 22 Feb 2002 19:02:56 -0500 [thread overview]
Message-ID: <20020222190256.C16169@redhat.com> (raw)
In-Reply-To: <F24fGB9wIWXLU9778dv00003562@hotmail.com>
In-Reply-To: <F24fGB9wIWXLU9778dv00003562@hotmail.com>; from balbir_soni@hotmail.com on Fri, Feb 22, 2002 at 12:28:14PM -0800
On Fri, Feb 22, 2002 at 12:28:14PM -0800, Balbir Singh wrote:
> Check if the alloc_fn and free_fn are not NULL. The caller generally
> ensures that alloc_fn and free_fn are valid. It would not harm
> to check. This makes the checking in mempool_create() more complete.
Rather than leak memory in that case, why not just BUG_ON null
function pointers so that people know what code is at fault?
-ben
next prev parent reply other threads:[~2002-02-23 0:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-22 20:28 [PATCH] Trivial patch against mempool Balbir Singh
2002-02-22 21:40 ` Marcus Alanen
2002-02-23 0:02 ` Benjamin LaHaise [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-02-22 21:59 Balbir Singh
2002-02-23 0:37 Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020222190256.C16169@redhat.com \
--to=bcrl@redhat.com \
--cc=balbir_soni@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox