Re: [PATCH] 2.5.5-pre1 IDE cleanup 9

Jeff Garzik
2002-02-22T14:47:06Z

Vojtech Pavlik wrote:
> On Fri, Feb 22, 2002 at 03:16:22PM +0100, Martin Dalecki wrote:
> > > I think it'd be even better if the chipset drivers did the probing
> > > themselves, and once they find the IDE device, they can register it with
> > > the IDE core. Same as all the other subsystem do this.
> >
> > Well the lists are needed for quirk handling in the ide-pci.c code.
> > But if it turns out to be possible - I'm all for it.
>
> I don't think so. If needed we can make some generic IDE_QUIRK_XXX
> defines which then the chipset drivers can use where applicable, passing
> them to the generic code.

It depends on the quirk, really, whether you want the low-level chipset
driver to set a flag that tells the IDE core to do something, or whether
the low-level chipset driver handles the quirk (by a fixup in an IRQ
routine or somesuch).

Basically it's a case-by-case basis...

--
Jeff Garzik | "UNIX enhancements aren't."
Building 1024 | -- says /usr/games/fortune
MandrakeSoft |