Re: Flash Back -- kernel 2.1.111

Linus Torvalds
2002-02-24T06:02:57Z

On Sat, 23 Feb 2002, Andre Hedrick wrote:
>
> Lets both grow up!

I repeat, as I did in a private to-you-only email before: every _single_
complain you have had about the patches I've seen has been 100% bogus.

The patch was called "IDE cleanup", and cleanup it was. Nothing but. The
timings didn't change, although the stupid (twice duplicated) functions
that "calculated" them were removed and replaces with one boot-time
calculation.

Martin not only had "cleanup" in the subject line, but actually explained
all the changes, including the timing change. The comments at the top of
the patch mail said (on that particular change, which seems to have been
your favourite target), typos and all:

3. Replace the functionally totally equal system_bus_block() and
ide_system_bus_speed() functions with one simple global
variable: system_bus_speed. This saves quite a significatn amount of
code. Unfortunately this is the part, which is makeing this
patch to appear bigger then it really is...

and the patch itself certainly agrees with what Martin claimed.

Your ranting, both on linux-kernel and on the IRC channels, has been
totally bogus, as if you didn't read either the explanation _or_ the
actual patch itself. And pointing this out multiple times doesn't seem to
have made any difference.

Linus