public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ken Brownfield <brownfld@irridia.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RFC] ServerWorks autodma behavior
Date: Tue, 26 Feb 2002 04:19:24 -0600	[thread overview]
Message-ID: <20020226041924.B930@asooo.flowerfire.com> (raw)
In-Reply-To: <20020226032629.A930@asooo.flowerfire.com> <E16feI5-0008WC-00@the-village.bc.nu>
In-Reply-To: <E16feI5-0008WC-00@the-village.bc.nu>; from alan@lxorguk.ukuu.org.uk on Tue, Feb 26, 2002 at 09:52:57AM +0000

On Tue, Feb 26, 2002 at 09:52:57AM +0000, Alan Cox wrote:
| > I have a lot of ServerWorks OSB4 IDE hardware, which has the annoyingly
| > suboptimal behavior of corrupting filesystems when DMA is active.
| 
| With newer kernels you should get a panic because we spot the "I'm going
| to get 4 bytes stuck in the FIFO and DMA your inodes shifted 4 bytes down the
| disk behaviour" - at least in the cases I could study
| 
| What set up do you have ?

These machines are Tyan Thunder LE (S2510) non-SCSI boards with Seagate
drives.  Dual-P3.

| > Unfortunately, serverworks.c (in recent 2.4, at least) does not honor
| > the CONFIG_IDEDMA_AUTO config option -- it turns dma on only unless
| > "ide=nodma" is set on the kernel command line.
| 
| You actually really to just turn off UDMA from experience.

Yeah -- but I'd like to be able to enable it if I need the performance
on a more DMA-able motherboard.  Turning it off entirely would have
worked, of course.

| >  	if (hwif->dma_base) {
| > +#ifdef CONFIG_IDEDMA_AUTO
| >  		if (!noautodma)
| >  			hwif->autodma = 1;
| > +#endif
| 
| I would have expected this to be a fix in the core code to ignore
| hwif->autodma but I'll admit I've not looked to see if that is practical.

That may be -- I was sticking with the obvious, least-invasive, least
IDE-core-clued evaluation. :)  This is also the same treatment of
noautodma found in the VIA driver.  The autodma setting from ide-pci
does seem to be correct -- deleting the code segment produces the same
DMA end-results, in the end, for ServerWorks.

Thanks much,
-- 
Ken.
brownfld@irridia.com


  parent reply	other threads:[~2002-02-26 10:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-26  9:26 [PATCH][RFC] ServerWorks autodma behavior Ken Brownfield
2002-02-26  9:52 ` Alan Cox
2002-02-26  9:37   ` Andre Hedrick
2002-02-26 10:27     ` Ken Brownfield
2002-02-26 10:50       ` Andre Hedrick
2002-02-26 19:14         ` Gunther Mayer
2002-02-26 10:19   ` Ken Brownfield [this message]
2002-02-26 11:12 ` Martin Dalecki
2002-02-27  1:01   ` Ken Brownfield
2002-02-27 10:21     ` Martin Dalecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020226041924.B930@asooo.flowerfire.com \
    --to=brownfld@irridia.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox