Re: [PATCH][RFC] ServerWorks autodma behavior

[Ken Brownfield <brownfld@irridia.com>]

On Tue, Feb 26, 2002 at 12:12:46PM +0100, Martin Dalecki wrote:
| Ken Brownfield wrote:
[...]
| > In any case, I've appended the patch I'm using to be able to turn off
| > auto-DMA at config-time rather than run-time for ServerWorks.  One
| > alternative is to shed this code altogether, since ide-pci.c seems to
| > set a rational default.
| 
| I think (not 100% becouse not re-checked against the code),
| you could just have removed the lines
| 
| if (!noautodma)
| 	hwif->autodma = 1;
| 
| and all should be well ;-).

Yes, and that's what I found as well.  That was my first patch until I
noticed the AUTO check in the VIA driver around this same code.

That being said, which of these solutions is worthy of going into the
kernel (if any) and should that decision be applied to the other IDE
drivers?

I feel like I'm okay with my own little patchbase, but this seems like a
useful type of change to make for everyone and all drivers in 2.4 (and
2.5 if it's even still applicable).  And it's just dirt simple enough
for me to do it. ;)

Thanks,
-- 
Ken.
brownfld@irridia.com