From: Dave Jones <davej@suse.de>
To: Marcelo Tossati <marcelo@conectiva.com.br>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] 2.4 bluesmoke fixes.
Date: Tue, 26 Feb 2002 23:52:25 +0000 [thread overview]
Message-ID: <20020226235225.A27562@suse.de> (raw)
Seems every time I look at this file I spot something else wrong.
First bug is a simple ordering problem.
Second bug already got fixed once recently, and somehow got lost.
Weird. Applies to 2.4.18, and any derivative thereof.
diff -urN --exclude-from=/home/davej/.exclude linux-2.4.18-ac2/arch/i386/kernel/bluesmoke.c linux-2.4.18-ac2-dj/arch/i386/kernel/bluesmoke.c
--- linux-2.4.18-ac2/arch/i386/kernel/bluesmoke.c Tue Feb 26 23:44:17 2002
+++ linux-2.4.18-ac2-dj/arch/i386/kernel/bluesmoke.c Tue Feb 26 23:49:15 2002
@@ -41,13 +41,12 @@
if(high&(1<<27))
{
rdmsr(MSR_IA32_MC0_MISC+i*4, alow, ahigh);
- printk("[%08x%08x]", alow, ahigh);
+ printk("[%08x%08x]", ahigh, alow);
}
if(high&(1<<26))
{
rdmsr(MSR_IA32_MC0_ADDR+i*4, alow, ahigh);
- printk(" at %08x%08x",
- high, low);
+ printk(" at %08x%08x", ahigh, alow);
}
printk("\n");
/* Clear it */
--
Dave Jones. http://www.codemonkey.org.uk
SuSE Labs.
reply other threads:[~2002-02-26 23:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020226235225.A27562@suse.de \
--to=davej@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox