* Simple cyberjack diff
@ 2002-02-26 22:16 Shane Nay
2002-02-27 4:16 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Shane Nay @ 2002-02-26 22:16 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-usb
While looking around the usb code I noticed this semaphore problem in
cyberjack. Anyway, it's a quicky.
Thanks,
Shane Nay.
--- virgin/linux/drivers/usb/serial/cyberjack.c Fri Dec 21 09:41:55 2001
+++ linux/drivers/usb/serial/cyberjack.c Tue Feb 26 14:09:31 2002
@@ -238,7 +238,8 @@
if( (count+priv->wrfilled)>sizeof(priv->wrbuf) ) {
/* To much data for buffer. Reset buffer. */
priv->wrfilled=0;
- return (0);
+ count=0;
+ goto exit;
}
/* Copy data */
@@ -299,7 +300,7 @@
priv->wrsent=0;
}
}
-
+exit:
up (&port->sem);
return (count);
}
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Simple cyberjack diff
2002-02-26 22:16 Simple cyberjack diff Shane Nay
@ 2002-02-27 4:16 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2002-02-27 4:16 UTC (permalink / raw)
To: Shane Nay; +Cc: linux-kernel, linux-usb
On Tue, Feb 26, 2002 at 02:16:35PM -0800, Shane Nay wrote:
> While looking around the usb code I noticed this semaphore problem in
> cyberjack. Anyway, it's a quicky.
Good catch. I'll add it to my 2.4 and 2.5 trees and push the changes
onward.
The same problem is also in the copy_from_user() test a few lines below
this one. I'll fix it.
thanks again,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-02-27 4:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-02-26 22:16 Simple cyberjack diff Shane Nay
2002-02-27 4:16 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox