From: Andrey Panin <pazke@orbita1.ru>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] EXPORT_SYMBOL(i8253_lock) in arch/i386/kernel/time.c
Date: Tue, 5 Mar 2002 12:34:42 +0300 [thread overview]
Message-ID: <20020305093302.GA283@pazke.ipt> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 678 bytes --]
Hi all,
in arch/i386/kernel/time.c (2.5.6-pre2) we make EXPORT_SYMBOL(i8253_lock), but
- linux/module.h isn't included in time.c;
- time.o isn't declared as export-objs in Makefile.
So we have theses warnings during kernel compilation:
time.c:118: warning: type defaults to `int' in declaration of `EXPORT_SYMBOL'
time.c:118: warning: parameter names (without types) in function declaration
time.c:118: warning: data definition has no type or storage class
Attached patch fixes these buglets, please consider applying.
Best regards.
--
Andrey Panin | Embedded systems software engineer
pazke@orbita1.ru | PGP key: wwwkeys.eu.pgp.net
[-- Attachment #1.2: patch-time-export-symbol --]
[-- Type: text/plain, Size: 978 bytes --]
diff -urN -X /usr/share/dontdiff /linux/arch/i386/kernel/Makefile /root/linux/arch/i386/kernel/Makefile
--- /linux/arch/i386/kernel/Makefile Wed Jan 30 00:58:18 2002
+++ /root/linux/arch/i386/kernel/Makefile Mon Mar 4 22:07:12 2002
@@ -14,7 +14,7 @@
O_TARGET := kernel.o
-export-objs := mca.o mtrr.o msr.o cpuid.o microcode.o i386_ksyms.o
+export-objs := mca.o mtrr.o msr.o cpuid.o microcode.o time.o i386_ksyms.o
obj-y := process.o semaphore.o signal.o entry.o traps.o irq.o vm86.o \
ptrace.o i8259.o ioport.o ldt.o setup.o time.o sys_i386.o \
diff -urN -X /usr/share/dontdiff /linux/arch/i386/kernel/time.c /root/linux/arch/i386/kernel/time.c
--- /linux/arch/i386/kernel/time.c Thu Jan 31 23:16:50 2002
+++ /root/linux/arch/i386/kernel/time.c Mon Mar 4 22:01:43 2002
@@ -41,6 +41,7 @@
#include <linux/delay.h>
#include <linux/init.h>
#include <linux/smp.h>
+#include <linux/module.h>
#include <asm/io.h>
#include <asm/smp.h>
[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]
reply other threads:[~2002-03-05 9:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020305093302.GA283@pazke.ipt \
--to=pazke@orbita1.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox