Re: Fwd: [Lse-tech] get_pid() performance fix

Rusty Russell
2002-03-07T03:53:34Z

On Mon, 4 Mar 2002 20:57:49 -0500
Hubertus Franke <frankeh@watson.ibm.com> wrote:

>
> Can somebody post why this patch shouldn't be picked up ?
> The attached program shows the problem in user space
> and the patch is almost trivial ..

At a cursory glance, this seems to be three patches:
1) Fix the get_pid() hang.
2) Speed up get_pid().
3) And this piece I'm not sure about:
> + if(p->tgid > last_pid && next_safe > p->tgid)
> + next_safe = p->tgid;

Please split, and send the fix get_pid() hang to trivial patch monkey,
and push optimization to Linus.

Cheers!
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.