public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: beezly@beezly.org.uk
Cc: linux-kernel@vger.kernel.org
Subject: Re: Sun GEM card looses TX on x86 32bit PCI
Date: Tue, 12 Mar 2002 09:31:34 -0800 (PST)	[thread overview]
Message-ID: <20020312.093134.35196670.davem@redhat.com> (raw)
In-Reply-To: <1015887102.2051.4.camel@monkey>
In-Reply-To: <1015881102.4312.10.camel@monkey> <1015881814.4315.12.camel@monkey> <1015887102.2051.4.camel@monkey>

   From: Beezly <beezly@beezly.org.uk>
   Date: 11 Mar 2002 22:51:42 +0000

   Ok, I've been fiddling around with the driver tonight and have managed
   to get a little further by forcing the driver to do a full reset of the
   chip when the RX buffer over flows. I achieved this by sticking a return
   1; at the top of gem_rxmac_reset().
   
   I'm guessing this isn't an "optimal" reset for the situation but so far
   it's having /reasonable/ results (i.e. I don't have to bring the
   interface up and down every 30 seconds!).
 ...   
   Hope this helps,

I'll follow up on this and figure out why my RX reset code
isn't working after I finish up some 2.5.x work.

But looking quickly I think I see what is wrong.  Please give
this a try (and remember to remove your hacks before testing
this :-):

--- drivers/net/sungem.c.~1~	Mon Mar 11 04:24:13 2002
+++ drivers/net/sungem.c	Tue Mar 12 09:30:38 2002
@@ -357,6 +357,7 @@ static int gem_rxmac_reset(struct gem *g
 
 		rxd->status_word = cpu_to_le64(RXDCTRL_FRESH(gp));
 	}
+	gp->rx_new = gp->rx_old = 0;
 
 	/* Now we must reprogram the rest of RX unit. */
 	desc_dma = (u64) gp->gblock_dvma;

  reply	other threads:[~2002-03-12 17:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-10 20:36 Sun GEM card looses TX on x86 32bit PCI Beezly
2002-03-11  0:43 ` David S. Miller
2002-03-11  8:19   ` Beezly
2002-03-11 12:19     ` Beezly
2002-03-11 12:21       ` David S. Miller
2002-03-11 18:35         ` Beezly
2002-03-11 19:02           ` David S. Miller
2002-03-11 21:11             ` Beezly
2002-03-11 21:23               ` Beezly
2002-03-11 22:51                 ` Beezly
2002-03-12 17:31                   ` David S. Miller [this message]
2002-03-12 20:34                     ` Beezly
2002-03-12 20:39                       ` David S. Miller
2002-03-14 20:43                     ` Aaron Sethman
2002-03-14 21:21                       ` Aaron Sethman
2002-03-11  1:39 ` David S. Miller
2002-03-11  1:58   ` David S. Miller
2002-03-11  8:29     ` Beezly
2002-03-11  8:42       ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020312.093134.35196670.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=beezly@beezly.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox