public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Mario 'BitKoenig' Holbe" <Mario.Holbe@RZ.TU-Ilmenau.DE>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] ACPI: kbd-pw-on/WOL don't work anymore since 2.4.14
Date: Tue, 12 Mar 2002 16:08:58 +0100	[thread overview]
Message-ID: <20020312150858.GB1108@darkside.ddts.net> (raw)
In-Reply-To: <20020310180526.GA1135@darkside.ddts.net> <20020311203438.GD332@elf.ucw.cz>
In-Reply-To: <20020311203438.GD332@elf.ucw.cz>

On Mon, Mar 11, 2002 at 09:34:39PM +0100, Pavel Machek wrote:
> I guess this needs to be runtime-configurable at least. It is probably
> bug. Introducing the config option is not right fix.

Yes, you are right.
But as I told: It was the least invasive method for me.

Applying it as a config option, would include adding a MODULE_PARM
section, which doesn't exist yet (not for me, I have ACPI compiled
into the kernel, but to keep it consistent even if compiled as
module). I'm not *that* proof with linux kernel source to guarantee
side-effect-freeness and so on.

This part I'd like to leave for developers knowing better, what
they're doing :)

However, if someone of the ACPI developers or someone of the
patch-acceptors (:)) tells me 'do it, we'll patch it in', I'll do
it.
If it has no chance to get in, I wont do it - for me myself, my
patch is quite enough :)


thanks for your response & regards,
   Mario
-- 
Mario 'BitKoenig' Holbe <Mario.Holbe@RZ.TU-Ilmenau.DE>

"Why are we hiding from the police, daddy?"      | J. E. Guenther
"Because we use SuSE son, they use SYSVR4."      | de.alt.sysadmin.recovery

  reply	other threads:[~2002-03-12 15:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-10 18:05 [patch] ACPI: kbd-pw-on/WOL don't work anymore since 2.4.14 Mario 'BitKoenig' Holbe
2002-03-11 20:34 ` Pavel Machek
2002-03-12 15:08   ` Mario 'BitKoenig' Holbe [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-03-12 19:57 Grover, Andrew
2002-03-12 20:40 ` Patrick Mochel
2002-03-12 22:38 ` Mario 'BitKoenig' Holbe
2002-03-12 21:51 Grover, Andrew
2002-03-12 23:05 Grover, Andrew
2002-03-12 23:13 ` Mario 'BitKoenig' Holbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020312150858.GB1108@darkside.ddts.net \
    --to=mario.holbe@rz.tu-ilmenau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox