Re: 2.4.19pre2aa1

Andrew Morton
2002-03-13T00:11:37Z

wli@holomorphy.com wrote:
>
> Also, these changes to the hashing scheme were not separated out
> from the rest of the VM patch, so the usual "break this up
> into a separate patch please" applies.

FYI, I am doing that at present. It look like Andrea's 10_vm-30
patch will end up as twenty or thirty separate patches. I won't
be testing every darn patch individually - I'll batch them up into
maybe four groups for testing and merging.

Andrea introduced some subtly changed buffer locking rules, and
this causes ext3 to deadlock under heavy load. Until we sort
this out, I'm afraid that the -aa VM is not suitable for production
use with ext3.

ext2 is OK and I *assume* it's OK with reiserfs. The problem occurs
when a filesystem performs:

lock_buffer(dirty_bh);
allocate_something(GFP_NOFS);

without having locked the buffer's page. sync_page_buffers()
can perform a wait_on_buffer() against dirty_bh. (I think.
I'm not quite up-to-speed with the new buffer state bits yet).

-