* CONFIG_SOUND_GAMEPORT in 2.5 @ 2002-03-13 15:27 Guennadi Liakhovetski 2002-03-13 17:20 ` Vojtech Pavlik 0 siblings, 1 reply; 6+ messages in thread From: Guennadi Liakhovetski @ 2002-03-13 15:27 UTC (permalink / raw) To: ARM Linux kernel, linux-kernel Hello everybody. The following extract from drivers/input/gameport/Config.in doesn't seem quite right to me, in general and for ARM specifically: if [ "$CONFIG_GAMEPORT" = "m" ]; then define_tristate CONFIG_SOUND_GAMEPORT m fi if [ "$CONFIG_GAMEPORT" != "m" ]; then define_tristate CONFIG_SOUND_GAMEPORT y fi Could the maintainer please change this? Thanks Guennadi --------------------------------- Guennadi Liakhovetski, Ph.D. DSA Daten- und Systemtechnik GmbH Pascalstr. 28 D-52076 Aachen Germany ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: CONFIG_SOUND_GAMEPORT in 2.5 2002-03-13 15:27 CONFIG_SOUND_GAMEPORT in 2.5 Guennadi Liakhovetski @ 2002-03-13 17:20 ` Vojtech Pavlik 2002-03-14 8:12 ` Guennadi Liakhovetski 0 siblings, 1 reply; 6+ messages in thread From: Vojtech Pavlik @ 2002-03-13 17:20 UTC (permalink / raw) To: Guennadi Liakhovetski; +Cc: ARM Linux kernel, linux-kernel On Wed, Mar 13, 2002 at 04:27:49PM +0100, Guennadi Liakhovetski wrote: > Hello everybody. The following extract from > drivers/input/gameport/Config.in doesn't seem quite right to me, in > general and for ARM specifically: > if [ "$CONFIG_GAMEPORT" = "m" ]; then > define_tristate CONFIG_SOUND_GAMEPORT m > fi > if [ "$CONFIG_GAMEPORT" != "m" ]; then > define_tristate CONFIG_SOUND_GAMEPORT y > fi > > Could the maintainer please change this? What's the problem here? -- Vojtech Pavlik SuSE Labs ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: CONFIG_SOUND_GAMEPORT in 2.5 2002-03-13 17:20 ` Vojtech Pavlik @ 2002-03-14 8:12 ` Guennadi Liakhovetski 2002-03-14 8:19 ` Vojtech Pavlik 0 siblings, 1 reply; 6+ messages in thread From: Guennadi Liakhovetski @ 2002-03-14 8:12 UTC (permalink / raw) To: Vojtech Pavlik; +Cc: linux-kernel > > drivers/input/gameport/Config.in doesn't seem quite right to me, in > > general and for ARM specifically: > > if [ "$CONFIG_GAMEPORT" = "m" ]; then > > define_tristate CONFIG_SOUND_GAMEPORT m > > fi > > if [ "$CONFIG_GAMEPORT" != "m" ]; then > > define_tristate CONFIG_SOUND_GAMEPORT y > > fi > > > > Could the maintainer please change this? > > What's the problem here? The problem is, that if you don't have anything like a sound-card/gameport at all, CONFIG_SOUND_GAMEPORT still will be YES. Ok, I didn't check in the code, maybe it doesn't add a single byte to the kernel, .config looks a bit confusing, doesn't it? Thanks Guennadi --------------------------------- Guennadi Liakhovetski, Ph.D. DSA Daten- und Systemtechnik GmbH Pascalstr. 28 D-52076 Aachen Germany ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: CONFIG_SOUND_GAMEPORT in 2.5 2002-03-14 8:12 ` Guennadi Liakhovetski @ 2002-03-14 8:19 ` Vojtech Pavlik 2002-03-14 9:07 ` Guennadi Liakhovetski 0 siblings, 1 reply; 6+ messages in thread From: Vojtech Pavlik @ 2002-03-14 8:19 UTC (permalink / raw) To: Guennadi Liakhovetski; +Cc: linux-kernel On Thu, Mar 14, 2002 at 09:12:04AM +0100, Guennadi Liakhovetski wrote: > > > drivers/input/gameport/Config.in doesn't seem quite right to me, in > > > general and for ARM specifically: > > > if [ "$CONFIG_GAMEPORT" = "m" ]; then > > > define_tristate CONFIG_SOUND_GAMEPORT m > > > fi > > > if [ "$CONFIG_GAMEPORT" != "m" ]; then > > > define_tristate CONFIG_SOUND_GAMEPORT y > > > fi > > > > > > Could the maintainer please change this? > > > > What's the problem here? > > The problem is, that if you don't have anything like a sound-card/gameport > at all, CONFIG_SOUND_GAMEPORT still will be YES. Ok, I didn't check in the > code, maybe it doesn't add a single byte to the kernel, .config looks a > bit confusing, doesn't it? Yes, it doesn't add anything. It's just a switch that *disables* gameport code in sound drivers if no gameport support is selected in the kernel. -- Vojtech Pavlik SuSE Labs ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: CONFIG_SOUND_GAMEPORT in 2.5 2002-03-14 8:19 ` Vojtech Pavlik @ 2002-03-14 9:07 ` Guennadi Liakhovetski 2002-03-14 9:12 ` Vojtech Pavlik 0 siblings, 1 reply; 6+ messages in thread From: Guennadi Liakhovetski @ 2002-03-14 9:07 UTC (permalink / raw) To: Vojtech Pavlik; +Cc: linux-kernel > > The problem is, that if you don't have anything like a sound-card/gameport > > at all, CONFIG_SOUND_GAMEPORT still will be YES. Ok, I didn't check in the > > code, maybe it doesn't add a single byte to the kernel, .config looks a > > bit confusing, doesn't it? > > Yes, it doesn't add anything. It's just a switch that *disables* > gameport code in sound drivers if no gameport support is selected in the > kernel. Sorry, did I get it right - if it is set to "yes", then it DISABLES gameport code?... Hm... Ok, as long as it doesn't add anything, I better shut up now, but, seems to me, it does look confusing... Thanks Guennadi --------------------------------- Guennadi Liakhovetski, Ph.D. DSA Daten- und Systemtechnik GmbH Pascalstr. 28 D-52076 Aachen Germany ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: CONFIG_SOUND_GAMEPORT in 2.5 2002-03-14 9:07 ` Guennadi Liakhovetski @ 2002-03-14 9:12 ` Vojtech Pavlik 0 siblings, 0 replies; 6+ messages in thread From: Vojtech Pavlik @ 2002-03-14 9:12 UTC (permalink / raw) To: Guennadi Liakhovetski; +Cc: Vojtech Pavlik, linux-kernel On Thu, Mar 14, 2002 at 10:07:22AM +0100, Guennadi Liakhovetski wrote: > > > The problem is, that if you don't have anything like a sound-card/gameport > > > at all, CONFIG_SOUND_GAMEPORT still will be YES. Ok, I didn't check in the > > > code, maybe it doesn't add a single byte to the kernel, .config looks a > > > bit confusing, doesn't it? > > > > Yes, it doesn't add anything. It's just a switch that *disables* > > gameport code in sound drivers if no gameport support is selected in the > > kernel. > > Sorry, did I get it right - if it is set to "yes", then it DISABLES > gameport code?... Hm... Ok, as long as it doesn't add anything, I better > shut up now, but, seems to me, it does look confusing... No, if it is set to yes, it allows the gameport code in the sound drivers. If set to no, it disables it. All only if the sound drivers which have gameport code in them are enabled. -- Vojtech Pavlik SuSE Labs ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2002-03-14 9:12 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2002-03-13 15:27 CONFIG_SOUND_GAMEPORT in 2.5 Guennadi Liakhovetski 2002-03-13 17:20 ` Vojtech Pavlik 2002-03-14 8:12 ` Guennadi Liakhovetski 2002-03-14 8:19 ` Vojtech Pavlik 2002-03-14 9:07 ` Guennadi Liakhovetski 2002-03-14 9:12 ` Vojtech Pavlik
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox