From: Anton Blanchard <anton@samba.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: bit ops on unsigned long?
Date: Sat, 16 Mar 2002 12:00:21 +1100 [thread overview]
Message-ID: <20020316010021.GD3280@krispykreme> (raw)
In-Reply-To: <E16m2Qu-0007mc-00@wagner.rustcorp.com.au>
In-Reply-To: <E16m2Qu-0007mc-00@wagner.rustcorp.com.au>
> nfs is broken in 2.5 ATM because it does set_bit on an "int".
> Can be *please* just bite the bullet and change the prototype on these
> ops so we stop seeing the same mistakes over and over?
I present to you Exhibit A:
diff -urN linux-2.5/include/linux/sunrpc/svcsock.h linux-2.5_tmp/include/linux/sunrpc/svcsock.h
--- linux-2.5/include/linux/sunrpc/svcsock.h Tue Mar 5 11:45:35 2002
+++ linux-2.5_tmp/include/linux/sunrpc/svcsock.h Sat Mar 16 11:41:02 2002
@@ -22,7 +22,7 @@
struct svc_serv * sk_server; /* service for this socket */
unsigned char sk_inuse; /* use count */
- unsigned int sk_flags;
+ unsigned long sk_flags;
#define SK_BUSY 0 /* enqueued/receiving */
#define SK_CONN 1 /* conn pending */
#define SK_CLOSE 2 /* dead or dying */
prev parent reply other threads:[~2002-03-16 1:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-16 0:52 bit ops on unsigned long? Rusty Russell
2002-03-16 0:58 ` Linus Torvalds
2002-03-16 3:08 ` Rusty Russell
2002-03-18 4:08 ` David S. Miller
2002-03-18 6:03 ` Jeff Garzik
2002-03-18 6:43 ` David S. Miller
2002-03-18 9:13 ` Rusty Russell
2002-03-25 2:45 ` Richard Gooch
2002-03-25 4:27 ` Rusty Russell
2002-03-25 6:21 ` Richard Gooch
2002-03-25 7:07 ` Rusty Russell
2002-03-25 7:12 ` Richard Gooch
2002-03-16 1:00 ` Anton Blanchard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020316010021.GD3280@krispykreme \
--to=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox