public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@zip.com.au>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: aa-110-zone_accounting
Date: Wed, 20 Mar 2002 10:02:21 +0000	[thread overview]
Message-ID: <20020320100221.B1730@infradead.org> (raw)
In-Reply-To: <3C9808EE.B5C38E84@zip.com.au>

> +void delta_nr_active_pages(struct page *page, long delta)
> +{
> +	pg_data_t * __pgdat;
> +	zone_t * __classzone, * __overflow;
> +
> +	__classzone = page_zone(page);
> +	__pgdat = __classzone->zone_pgdat;
> +	__overflow = __pgdat->node_zones + __pgdat->nr_zones;

Double-underscroes for local variables are very bad style.
Could you change this?


  reply	other threads:[~2002-03-20 10:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-20  3:58 aa-110-zone_accounting Andrew Morton
2002-03-20 10:02 ` Christoph Hellwig [this message]
2002-03-20 10:56 ` aa-110-zone_accounting Bill Davidsen
2002-03-20 13:45 ` aa-110-zone_accounting Rik van Riel
2002-03-20 19:11   ` aa-110-zone_accounting Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020320100221.B1730@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@zip.com.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox