Hooks for random device entropy generation missing in cpqarray.c

Hooks for random device entropy generation missing in cpqarray.c

[Manon Goo]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

Hi,

All hooks for the random ganeration (add_blkdev_randomness() ) are ignored 
in the cpqarray / ida  driver.
	Is a patch available ?
	or an other updated driver ?
	any hints where to put add_blkdev_randomness() in your driver ?

	is add_interrupt_randomness() called on an i386 SMP IO-APCI system ?


Thanks
Manon

PS: Folks on linux-kernel please CC to manon@manon.de I am not on the list



[-- Attachment #2: Type: application/pgp-signature, Size: 229 bytes --]

RE: Hooks for random device entropy generation missing in cpqarray.c

[White, Charles]

Yes.. I was reported that it some how got dropped from our 2.4 version of the driver.. 
DON'T add add_interrupt_randomness, just add "| SA_SAMPLE_RANDOM" to the call to request_irq. 

Patch to follow. 


-----Original Message-----
From: Manon Goo [mailto:manon@manon.de]
Sent: Wednesday, March 20, 2002 7:34 AM
To: Arrays
Cc: linux-kernel@vger.kernel.org; tytso@MIT.EDU; Markus Schröder
Subject: Hooks for random device entropy generation missing in
cpqarray.c 


Hi,

All hooks for the random ganeration (add_blkdev_randomness() ) are ignored 
in the cpqarray / ida  driver.
	Is a patch available ?
	or an other updated driver ?
	any hints where to put add_blkdev_randomness() in your driver ?
	
	is add_interrupt_randomness() called on an i386 SMP IO-APCI system ?


Thanks
Manon

PS: Folks on linux-kernel please CC to manon@manon.de I am not on the list

Re: Hooks for random device entropy generation missing in cpqarray.c

[Zwane Mwaikambo]

On Wed, 20 Mar 2002, Manon Goo wrote:

> All hooks for the random ganeration (add_blkdev_randomness() ) are ignored 
> in the cpqarray / ida  driver.
> 	Is a patch available ?
> 	or an other updated driver ?
> 	any hints where to put add_blkdev_randomness() in your driver ?

Its all handled by drivers/scsi/scsi_lib.c, its a generic service so is 
done for all drivers.

> is add_interrupt_randomness() called on an i386 SMP IO-APCI system ?

Yes, check out arch/i386/kernel/irq.c:handle_IRQ_event, irq.c is the 
generic code which sits on top of the real interrupt controller driver, be 
it an IOAPIC or regular PIC.

Cheers,
	Zwane

Re: Hooks for random device entropy generation missing in cpqarray.c

[Alan Cox]

> Its all handled by drivers/scsi/scsi_lib.c, its a generic service so is 
> done for all drivers.

Thats only for scsi ones. cpqarray appears as a block device

Re: Hooks for random device entropy generation missing in cpqarray.c

[Manon Goo]

[-- Attachment #1: Type: text/plain, Size: 958 bytes --]

No its is not there are certain bloc devices like cpqarray an mylex DAC960 
(which handles this correctly)
which do noether use the SCSI or the IDE driver.

Manon

--On Mittwoch, 20. März 2002 16:38 Uhr +0200 Zwane Mwaikambo 
<zwane@linux.realnet.co.sz> wrote:

> On Wed, 20 Mar 2002, Manon Goo wrote:
>
>> All hooks for the random ganeration (add_blkdev_randomness() ) are
>> ignored  in the cpqarray / ida  driver.
>> 	Is a patch available ?
>> 	or an other updated driver ?
>> 	any hints where to put add_blkdev_randomness() in your driver ?
>
> Its all handled by drivers/scsi/scsi_lib.c, its a generic service so is
> done for all drivers.
>
>> is add_interrupt_randomness() called on an i386 SMP IO-APCI system ?
>
> Yes, check out arch/i386/kernel/irq.c:handle_IRQ_event, irq.c is the
> generic code which sits on top of the real interrupt controller driver,
> be  it an IOAPIC or regular PIC.
>
> Cheers,
> 	Zwane
>
>


[-- Attachment #2: Type: application/pgp-signature, Size: 229 bytes --]

Re: Hooks for random device entropy generation missing in cpqarray.c

[Zwane Mwaikambo]

On Wed, 20 Mar 2002, Manon Goo wrote:

> No its is not there are certain bloc devices like cpqarray an mylex DAC960 
> (which handles this correctly)
> which do noether use the SCSI or the IDE driver.

Sorry, my mistake.

	Zwane

RE: Hooks for random device entropy generation missing in cpqarray.c

[Manon Goo]

[-- Attachment #1: Type: text/plain, Size: 1749 bytes --]

I have a quick and drity patch for 1 contorlller:

I patched as floows:



--- ./drivers/block/cpqarray.c.old      Wed Mar 20 14:53:16 2002
+++ drivers/block/cpqarray.c    Wed Mar 20 15:31:32 2002
@@ -1009,6 +1009,7 @@

 startio:
        start_io(h);
+       add_blkdev_randomness(MAJOR_NR);
 }

 /*


other Driver (handling more the 1 drive) find out the
Major driver number ...


./drivers/scsi/scsi_lib.c:      add_blkdev_randomness(MAJOR(req->rq_dev));
./drivers/ide/ide.c:            add_blkdev_randomness(MAJOR(rq->rq_dev));
./drivers/block/DAC960.c:         add_blkdev_randomness(DAC960_MAJOR + 
Controller->ControllerNumber);

How would I do this for the cpqarray ?

--On Mittwoch, 20. März 2002 8:25 Uhr -0600 "White, Charles" 
<Charles.White@COMPAQ.com> wrote:

> Yes.. I was reported that it some how got dropped from our 2.4 version of
> the driver..  DON'T add add_interrupt_randomness, just add "|
> SA_SAMPLE_RANDOM" to the call to request_irq.
>
> Patch to follow.
>
>
> -----Original Message-----
> From: Manon Goo [mailto:manon@manon.de]
> Sent: Wednesday, March 20, 2002 7:34 AM
> To: Arrays
> Cc: linux-kernel@vger.kernel.org; tytso@MIT.EDU; Markus Schröder
> Subject: Hooks for random device entropy generation missing in
> cpqarray.c
>
>
> Hi,
>
> All hooks for the random ganeration (add_blkdev_randomness() ) are
> ignored  in the cpqarray / ida  driver.
> 	Is a patch available ?
> 	or an other updated driver ?
> 	any hints where to put add_blkdev_randomness() in your driver ?
>
> 	is add_interrupt_randomness() called on an i386 SMP IO-APCI system ?
>
>
> Thanks
> Manon
>
> PS: Folks on linux-kernel please CC to manon@manon.de I am not on the list
>
>


[-- Attachment #2: Type: application/pgp-signature, Size: 229 bytes --]

Re: Hooks for random device entropy generation missing in cpqarray.c

[Dave Jones]

On Wed, Mar 20, 2002 at 05:06:54PM +0100, Manon Goo wrote:
 > I have a quick and drity patch for 1 contorlller:
 > ...
 >
 > --On Mittwoch, 20. März 2002 8:25 Uhr -0600 "White, Charles" 
 > <Charles.White@COMPAQ.com> wrote:
 > 
 > >Yes.. I was reported that it some how got dropped from our 2.4 version of
 > >the driver..  DON'T add add_interrupt_randomness, just add "|
 > >SA_SAMPLE_RANDOM" to the call to request_irq.
 > How would I do this for the cpqarray ?

 Exactly like Charles explained how to. See also...
 http://www.codemonkey.org.uk/patches/merged/2.5.4/dj2/random-cpqirq.diff
 if it still isnt' clear.
-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs

Re: Hooks for random device entropy generation missing in cpqarray.c

[Manon Goo]

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]

Hmmm in cpqarray.c this appers to be called in cpqarray_init() is this only
called when the driver initalizes or at every access ?


--On Mittwoch, 20. März 2002 17:16 Uhr +0100 Dave Jones <davej@suse.de> 
wrote:

> On Wed, Mar 20, 2002 at 05:06:54PM +0100, Manon Goo wrote:
>  > I have a quick and drity patch for 1 contorlller:
>  > ...
>  >
>  > --On Mittwoch, 20. März 2002 8:25 Uhr -0600 "White, Charles"
>  > <Charles.White@COMPAQ.com> wrote:
>  >
>  > >Yes.. I was reported that it some how got dropped from our 2.4
> version of  > >the driver..  DON'T add add_interrupt_randomness, just add
> "|  > >SA_SAMPLE_RANDOM" to the call to request_irq.
>  > How would I do this for the cpqarray ?
>
>  Exactly like Charles explained how to. See also...
>  http://www.codemonkey.org.uk/patches/merged/2.5.4/dj2/random-cpqirq.diff
>  if it still isnt' clear.
> --
>| Dave Jones.        http://www.codemonkey.org.uk
>| SuSE Labs


[-- Attachment #2: Type: application/pgp-signature, Size: 229 bytes --]

Re: Hooks for random device entropy generation missing in cpqarray.c

[Stephen Cameron]

On Wed, 20 Mar 2002, Manon Goo wrote:

> All hooks for the random ganeration (add_blkdev_randomness() ) 
> are ignored=20 in the cpqarray / ida  driver

Try OR-ing in SA_SAMPLE_RANDOM in the call to request_irq().

You don't say what kernel you're using, I think
this is already in the latest 2.2, 2.4, 2.5 kernels,
if I remember right... I see it in my copy of 2.2.21-pre3 
anyway.

-- steve

Re: Hooks for random device entropy generation missing in cpqarray.c

[Manon Goo]

[-- Attachment #1: Type: text/plain, Size: 569 bytes --]

excuse me I am using 2.4.18

Manon

--On Mittwoch, 20. März 2002 15:07 Uhr -0600 Stephen Cameron 
<steve.cameron@compaq.com> wrote:

> On Wed, 20 Mar 2002, Manon Goo wrote:
>
>> All hooks for the random ganeration (add_blkdev_randomness() )
>> are ignored=20 in the cpqarray / ida  driver
>
> Try OR-ing in SA_SAMPLE_RANDOM in the call to request_irq().
>
> You don't say what kernel you're using, I think
> this is already in the latest 2.2, 2.4, 2.5 kernels,
> if I remember right... I see it in my copy of 2.2.21-pre3
> anyway.
>
> -- steve
>


[-- Attachment #2: Type: application/pgp-signature, Size: 229 bytes --]