From: Andreas Dilger <adilger@clusterfs.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org, Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Subject: Re: [PATCH] Trivial request_region check patchset.
Date: Fri, 22 Mar 2002 00:48:14 -0700 [thread overview]
Message-ID: <20020322074814.GC3451@turbolinux.com> (raw)
In-Reply-To: <E16oIJ7-0000uW-00@wagner.rustcorp.com.au>
On Mar 22, 2002 17:13 +1100, Rusty Russell wrote:
> Evgeniy Polyakov <johnpol@2ka.mipt.ru> has been working his
> way through the kernel, auditing request_region calls (which as of 2.4
> return an int). Please peruse for your drivers before I send them all
> to Linus, and watch out for more mails from Evgeniy!
Thank you Evgeniy for this work. A very minor change request - please
follow the kernel CodingStyle:
if (!request_region(0xa0, 0x20, "pic2"))
{
release_region(0x20, 0x20);
return;
}
should be:
if (!request_region(0xa0, 0x20, "pic2")) {
release_region(0x20, 0x20);
return;
}
Cheers, Andreas
--
Andreas Dilger \ "If a man ate a pound of pasta and a pound of antipasto,
\ would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/ -- Dogbert
prev parent reply other threads:[~2002-03-22 7:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-22 6:13 [PATCH] Trivial request_region check patchset Rusty Russell
2002-03-22 7:48 ` Andreas Dilger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020322074814.GC3451@turbolinux.com \
--to=adilger@clusterfs.com \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox