public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleg Drokin <green@namesys.com>
To: Luigi Genoni <kernel@Expansa.sns.it>
Cc: linux-kernel@vger.kernel.org
Subject: Re: oops at boot with 2.5.7 and i810 (reiserFS related?)
Date: Fri, 22 Mar 2002 08:51:28 +0300	[thread overview]
Message-ID: <20020322085128.B6792@namesys.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0203211841010.21275-100000@Expansa.sns.it>

[-- Attachment #1: Type: text/plain, Size: 842 bytes --]

Hello!

On Thu, Mar 21, 2002 at 06:41:49PM +0100, Luigi Genoni wrote:

> It seems that a lot of users had oops mounting reiserFS with 2.5.6, but
> then a patch fixed that. Now I think this patch is in 2.5.7, (it should),
> but there are other changes i think to reiserFS code. So i have other
> oopses.

reiserfs in 2.5.6-pre3 to 2.5.7 have a bug that prevent it from mounting
usual filesystems (filesystems with relocated journals still works,
but I doubt much people use that).
 
> I think this could be a proof of a reiserFS bug.

Sure.

> If people at namesys need it (maybe they already know this, and have a
> patch to try), tomorrow i will post the oop mounting
> reiserFS.

No need for that. See attached patch that I am posting in response to
any such report (so just looking in archives first might help you faster).

Bye,
    Oleg

[-- Attachment #2: 00-jdev_bd_merging_fix.diff --]
[-- Type: text/plain, Size: 881 bytes --]

--- linux-2.5.6/fs/reiserfs/journal.c.orig	Tue Mar 12 15:25:27 2002
+++ linux-2.5.6/fs/reiserfs/journal.c	Tue Mar 12 15:26:47 2002
@@ -1958,8 +1958,7 @@
       		SB_ONDISK_JOURNAL_DEVICE( super ) ?
 		to_kdev_t(SB_ONDISK_JOURNAL_DEVICE( super )) : super -> s_dev;	
 	/* there is no "jdev" option and journal is on separate device */
-	if( ( !jdev_name || !jdev_name[ 0 ] ) && 
-	    SB_ONDISK_JOURNAL_DEVICE( super ) ) {
+	if( ( !jdev_name || !jdev_name[ 0 ] ) ) {
 		journal -> j_dev_bd = bdget( kdev_t_to_nr( jdev ) );
 		if( journal -> j_dev_bd )
 			result = blkdev_get( journal -> j_dev_bd, 
@@ -1974,9 +1973,6 @@
 		return result;
 	}
 
-	/* no "jdev" option and journal is on the host device */
-	if( !jdev_name || !jdev_name[ 0 ] )
-		return 0;
 	journal -> j_dev_file = filp_open( jdev_name, 0, 0 );
 	if( !IS_ERR( journal -> j_dev_file ) ) {
 		struct inode *jdev_inode;

  reply	other threads:[~2002-03-22  5:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-21 17:41 oops at boot with 2.5.7 and i810 (reiserFS related?) Luigi Genoni
2002-03-22  5:51 ` Oleg Drokin [this message]
2002-03-22 16:02   ` Luigi Genoni
  -- strict thread matches above, loose matches on Subject: below --
2002-03-20 16:57 oops at boot with 2.5.7 and i810 Martin Dalecki
2002-03-21  1:00 ` oops at boot with 2.5.7 and i810 (reiserFS related?) Luigi Genoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020322085128.B6792@namesys.com \
    --to=green@namesys.com \
    --cc=kernel@Expansa.sns.it \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox