public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Re: oops at boot with 2.5.7 and i810 (reiserFS related?)
  2002-03-20 16:57 oops at boot with 2.5.7 and i810 Martin Dalecki
@ 2002-03-21  1:00 ` Luigi Genoni
  0 siblings, 0 replies; 4+ messages in thread
From: Luigi Genoni @ 2002-03-21  1:00 UTC (permalink / raw)
  To: Martin Dalecki; +Cc: linux-kernel, vojtech, hans


Maybe you are right.
I tested a 2.5 kernel with another server with scsi adaptec, and
it worked with ext2 but oops while mounting reiserFS.

It seems that a lot of users had oops mounting reiserFS with 2.5.6, but
then a patch fixed that. Now I think this patch is in 2.5.7, (it should),
but there are other changes i think to reiserFS code. So i have other
oopses.

I think this could be a proof of a reiserFS bug.

If people at namesys need it (maybe they already know this, and have a
patch to try), tomorrow i will post the oop mounting
reiserFS.

Luigi

On Wed, 20 Mar 2002, Martin Dalecki wrote:

> Luigi Genoni wrote:
> > yes, as I said at the beginning
> >
>
> Ohhh... I did miss this apparently...
>
> OK. Anyway I'm quite confident that *this* particular
> flaw is nto caused by the ICH host chip code but by a dance between Hand and
> Alexander... instead.
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: oops at boot with 2.5.7 and i810 (reiserFS related?)
@ 2002-03-21 17:41 Luigi Genoni
  2002-03-22  5:51 ` Oleg Drokin
  0 siblings, 1 reply; 4+ messages in thread
From: Luigi Genoni @ 2002-03-21 17:41 UTC (permalink / raw)
  To: linux-kernel; +Cc: green




Maybe you are right.
I tested a 2.5 kernel with another server with scsi adaptec, and
it worked with ext2 but oops while mounting reiserFS.

It seems that a lot of users had oops mounting reiserFS with 2.5.6, but
then a patch fixed that. Now I think this patch is in 2.5.7, (it should),
but there are other changes i think to reiserFS code. So i have other
oopses.

I think this could be a proof of a reiserFS bug.

If people at namesys need it (maybe they already know this, and have a
patch to try), tomorrow i will post the oop mounting
reiserFS.

Luigi

On Wed, 20 Mar 2002, Martin Dalecki wrote:

> Luigi Genoni wrote:
> > yes, as I said at the beginning
> >
>
> Ohhh... I did miss this apparently...
>
> OK. Anyway I'm quite confident that *this* particular
> flaw is nto caused by the ICH host chip code but by a dance between Hand and
> Alexander... instead.
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: oops at boot with 2.5.7 and i810 (reiserFS related?)
  2002-03-21 17:41 oops at boot with 2.5.7 and i810 (reiserFS related?) Luigi Genoni
@ 2002-03-22  5:51 ` Oleg Drokin
  2002-03-22 16:02   ` Luigi Genoni
  0 siblings, 1 reply; 4+ messages in thread
From: Oleg Drokin @ 2002-03-22  5:51 UTC (permalink / raw)
  To: Luigi Genoni; +Cc: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 842 bytes --]

Hello!

On Thu, Mar 21, 2002 at 06:41:49PM +0100, Luigi Genoni wrote:

> It seems that a lot of users had oops mounting reiserFS with 2.5.6, but
> then a patch fixed that. Now I think this patch is in 2.5.7, (it should),
> but there are other changes i think to reiserFS code. So i have other
> oopses.

reiserfs in 2.5.6-pre3 to 2.5.7 have a bug that prevent it from mounting
usual filesystems (filesystems with relocated journals still works,
but I doubt much people use that).
 
> I think this could be a proof of a reiserFS bug.

Sure.

> If people at namesys need it (maybe they already know this, and have a
> patch to try), tomorrow i will post the oop mounting
> reiserFS.

No need for that. See attached patch that I am posting in response to
any such report (so just looking in archives first might help you faster).

Bye,
    Oleg

[-- Attachment #2: 00-jdev_bd_merging_fix.diff --]
[-- Type: text/plain, Size: 881 bytes --]

--- linux-2.5.6/fs/reiserfs/journal.c.orig	Tue Mar 12 15:25:27 2002
+++ linux-2.5.6/fs/reiserfs/journal.c	Tue Mar 12 15:26:47 2002
@@ -1958,8 +1958,7 @@
       		SB_ONDISK_JOURNAL_DEVICE( super ) ?
 		to_kdev_t(SB_ONDISK_JOURNAL_DEVICE( super )) : super -> s_dev;	
 	/* there is no "jdev" option and journal is on separate device */
-	if( ( !jdev_name || !jdev_name[ 0 ] ) && 
-	    SB_ONDISK_JOURNAL_DEVICE( super ) ) {
+	if( ( !jdev_name || !jdev_name[ 0 ] ) ) {
 		journal -> j_dev_bd = bdget( kdev_t_to_nr( jdev ) );
 		if( journal -> j_dev_bd )
 			result = blkdev_get( journal -> j_dev_bd, 
@@ -1974,9 +1973,6 @@
 		return result;
 	}
 
-	/* no "jdev" option and journal is on the host device */
-	if( !jdev_name || !jdev_name[ 0 ] )
-		return 0;
 	journal -> j_dev_file = filp_open( jdev_name, 0, 0 );
 	if( !IS_ERR( journal -> j_dev_file ) ) {
 		struct inode *jdev_inode;

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: oops at boot with 2.5.7 and i810 (reiserFS related?)
  2002-03-22  5:51 ` Oleg Drokin
@ 2002-03-22 16:02   ` Luigi Genoni
  0 siblings, 0 replies; 4+ messages in thread
From: Luigi Genoni @ 2002-03-22 16:02 UTC (permalink / raw)
  To: Oleg Drokin; +Cc: linux-kernel

Thanx,
it works ;)


On Fri, 22 Mar 2002, Oleg Drokin wrote:

> Hello!
>
> On Thu, Mar 21, 2002 at 06:41:49PM +0100, Luigi Genoni wrote:
>
> > It seems that a lot of users had oops mounting reiserFS with 2.5.6, but
> > then a patch fixed that. Now I think this patch is in 2.5.7, (it should),
> > but there are other changes i think to reiserFS code. So i have other
> > oopses.
>
> reiserfs in 2.5.6-pre3 to 2.5.7 have a bug that prevent it from mounting
> usual filesystems (filesystems with relocated journals still works,
> but I doubt much people use that).
>
> > I think this could be a proof of a reiserFS bug.
>
> Sure.
>
> > If people at namesys need it (maybe they already know this, and have a
> > patch to try), tomorrow i will post the oop mounting
> > reiserFS.
>
> No need for that. See attached patch that I am posting in response to
> any such report (so just looking in archives first might help you faster).
>
> Bye,
>     Oleg
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2002-03-22 16:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-03-21 17:41 oops at boot with 2.5.7 and i810 (reiserFS related?) Luigi Genoni
2002-03-22  5:51 ` Oleg Drokin
2002-03-22 16:02   ` Luigi Genoni
  -- strict thread matches above, loose matches on Subject: below --
2002-03-20 16:57 oops at boot with 2.5.7 and i810 Martin Dalecki
2002-03-21  1:00 ` oops at boot with 2.5.7 and i810 (reiserFS related?) Luigi Genoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox