From: "David S. Miller" <davem@redhat.com>
To: rusty@rustcorp.com.au
Cc: akpm@zip.com.au, marcelo@conectiva.com.br, linux-kernel@vger.kernel.org
Subject: Re: [patch] smaller kernels
Date: Sun, 24 Mar 2002 21:52:39 -0800 (PST) [thread overview]
Message-ID: <20020324.215239.61846157.davem@redhat.com> (raw)
In-Reply-To: <20020325165605.7d9c1d6e.rusty@rustcorp.com.au>
From: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon, 25 Mar 2002 16:56:05 +1100
And I'm not sure DaveM'll appreciate this:
> static inline char *__skb_pull(struct sk_buff *skb, unsigned int len)
> {
> skb->len-=len;
> - if (skb->len < skb->data_len)
> - BUG();
> return skb->data+=len;
> }
Rusty's right, I definitely won't take this, it catches problems
%99 of the time in the place that causes it.
next prev parent reply other threads:[~2002-03-25 5:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-20 6:11 [patch] smaller kernels Andrew Morton
2002-03-25 5:56 ` Rusty Russell
2002-03-25 5:52 ` David S. Miller [this message]
2002-03-25 19:49 ` Bill Davidsen
2002-03-25 6:09 ` Andrew Morton
2002-03-25 7:09 ` Rusty Russell
2002-03-25 22:22 ` Marcelo Tosatti
2002-03-26 0:12 ` Andrew Morton
2002-03-25 23:11 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020324.215239.61846157.davem@redhat.com \
--to=davem@redhat.com \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox