From: Steven Walter <srwalter@yahoo.com>
To: alan@lxorguk.ukuu.org.uk, davej@suse.de, torvalds@transmeta.com,
marcelo@conective.com.br
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Re: Screen corruption in 2.4.18
Date: Sun, 24 Mar 2002 09:59:30 -0600 [thread overview]
Message-ID: <20020324155930.GA20926@hapablap.dyn.dhs.org> (raw)
In-Reply-To: <200203192112.WAA09721@jagor.srce.hr> <1016953516.189201.5912.nullmailer@bozar.algorithm.com.au> <20020324071604.GA15618@hapablap.dyn.dhs.org> <200203241231.g2OCV5X18426@Port.imtp.ilyichevsk.odessa.ua>
This patch fixes a screen corruption bug seen on VIA KM133 mainboards.
As it stands, we disable bits 5, 6, and 7 of register offset 55 in order
to disable the memory write queue, which was causing us trouble before.
However, the clearing of bits 5 and 6 is causing us trouble now. Whenever
they're cleared, the screen gets static across it, roughly corresponding
to IDE/PCI activity. I spoke to one of the developers involved in the
original fix, and he suggested that we go ahead and not clear bits 5 and 6
on these boards, and that he was aware of several instances where clearing
them causes trouble.
Here is a patch which should apply cleanly to everyone's tree, which
only clears bit 7 on all chips except the KT266. No problems have been
reported there, so I'm leaving well enough alone. Please apply.
Thanks
--
-Steven
In a time of universal deceit, telling the truth is a revolutionary act.
-- George Orwell
He's alive. He's alive! Oh, that fellow at RadioShack said I was mad!
Well, who's mad now?
-- Montgomery C. Burns
--- linux/arch/i386/kernel/pci-pc.c~ Sun Mar 24 09:43:14 2002
+++ linux/arch/i386/kernel/pci-pc.c Sun Mar 24 09:43:23 2002
@@ -1197,16 +1197,19 @@
{
u8 v;
int where = 0x55;
+ int mask = 0x7f; /* Clearing bits 5 and 6 on the ProSavage KM133
+ * causes strange screen corruption, so we don't */
if (d->device == PCI_DEVICE_ID_VIA_8367_0) {
where = 0x95; /* the memory write queue timer register is
different for the kt266x's: 0x95 not 0x55 */
+ mask = 0x1f; /* clear bits 5, 6, 7 */
}
pci_read_config_byte(d, where, &v);
if (v & 0xe0) {
- printk("Disabling VIA memory write queue: [%02x] %02x->%02x\n", where, v, v & 0x1f);
- v &= 0x1f; /* clear bits 5, 6, 7 */
+ printk("Disabling VIA memory write queue: [%02x] %02x->%02x\n", where, v, v & mask);
+ v &= mask;
pci_write_config_byte(d, where, v);
}
}
next prev parent reply other threads:[~2002-03-24 16:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-19 21:12 Screen corruption in 2.4.18 Danijel Schiavuzzi
2002-03-20 0:03 ` Steven Walter
[not found] ` <200203201506.QAA13795@jagor.srce.hr>
[not found] ` <20020320172516.GA14024@hapablap.dyn.dhs.org>
[not found] ` <200203211209.NAA11121@jagor.srce.hr>
2002-03-21 17:22 ` Steven Walter
[not found] ` <200203222204.XAA01121@jagor.srce.hr>
2002-03-22 23:23 ` Steven Walter
[not found] ` <200203231526.QAA09302@jagor.srce.hr>
2002-03-23 16:06 ` Steven Walter
[not found] ` <200203231741.SAA00071@jagor.srce.hr>
2002-03-23 18:26 ` VIA technical contact [was Screen corruption in 2.4.18] Steven Walter
2002-03-24 7:05 ` Screen corruption in 2.4.18 Andre Pang
2002-03-24 7:16 ` [PATCH] " Steven Walter
[not found] ` <200203241231.g2OCV5X18426@Port.imtp.ilyichevsk.odessa.ua>
2002-03-24 15:59 ` Steven Walter [this message]
2002-03-24 16:48 ` Alan Cox
2002-03-24 18:03 ` Steven Walter
2002-03-25 2:01 ` Andre Pang
2002-03-24 15:07 ` Danijel Schiavuzzi
2002-03-24 16:51 ` Alan Cox
2002-03-24 17:13 ` Danijel Schiavuzzi
2002-03-25 1:43 ` Andre Pang
2002-03-25 2:40 ` Steven Walter
2002-03-25 3:00 ` Andre Pang
2002-03-25 8:50 ` Marc Wilson
2002-03-25 17:07 ` Daniel Gryniewicz
2002-03-25 21:02 ` Steven Walter
2002-03-25 21:19 ` Marc Wilson
2002-03-29 2:06 ` Andre Pang
2002-03-29 3:16 ` Marc Wilson
2002-03-25 1:55 ` Andre Pang
2002-03-25 19:52 ` Danijel Schiavuzzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020324155930.GA20926@hapablap.dyn.dhs.org \
--to=srwalter@yahoo.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davej@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conective.com.br \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox