From: Dave Jones <davej@suse.de>
To: Boris Bezlaj <boris@kista.gajba.net>
Cc: kernel-janitor-discuss
<kernel-janitor-discuss@lists.sourceforge.net>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: mdacon.c minor cleanups
Date: Sun, 24 Mar 2002 19:42:54 +0100 [thread overview]
Message-ID: <20020324194254.A14465@suse.de> (raw)
In-Reply-To: <20020323164220.742414d2.boris@kista.gajba.net>
On Sat, Mar 23, 2002 at 04:42:20PM +0100, Boris Bezlaj wrote:
> if (! mda_detect()) {
> - printk("mdacon: MDA card not detected.\n");
> + printk(KERN_WARNING __FILE__ ": MDA card not detected.\n");
> return NULL;
Does __FILE__ suffer the same 'deprecated' warning that newer gcc 3's
spit out for __FUNCTION__ ? If so, it'd be better to do this properly
than to add more bits that will just create another janitor item for
someone else later..
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
next prev parent reply other threads:[~2002-03-24 18:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-23 15:42 mdacon.c minor cleanups Boris Bezlaj
2002-03-24 5:38 ` Keith Owens
2002-03-24 18:42 ` Dave Jones [this message]
2002-03-24 18:59 ` Daniel Jacobowitz
2002-03-25 7:53 ` Zwane Mwaikambo
2002-03-25 15:50 ` Boris
2002-03-25 16:05 ` Zwane Mwaikambo
2002-03-27 9:17 ` Matan
2002-03-27 9:35 ` Zwane Mwaikambo
2002-03-27 17:56 ` Boris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020324194254.A14465@suse.de \
--to=davej@suse.de \
--cc=boris@kista.gajba.net \
--cc=kernel-janitor-discuss@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox