From: "Stephen C. Tweedie" <sct@redhat.com>
To: Andrew Morton <akpm@zip.com.au>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
lkml <linux-kernel@vger.kernel.org>,
ext2-devel@lists.sourceforge.net,
Stephen Tweedie <sct@redhat.com>
Subject: Re: [Ext2-devel] [patch] speed up ext3 synchronous mounts
Date: Mon, 25 Mar 2002 23:01:14 +0000 [thread overview]
Message-ID: <20020325230114.N4328@redhat.com> (raw)
In-Reply-To: <3C9E4A18.7DDC68AB@zip.com.au>
Hi,
On Sun, Mar 24, 2002 at 01:50:16PM -0800, Andrew Morton wrote:
> Again, we don't need to sync indirects as we dirty them because
> we run a commit if IS_SYNC(inode) prior to returning to the
> caller of write(2).
>
> Writing a 10 meg file in 0.1 meg chunks is sped up by, err,
> a factor of fifty. That's a best case.
>
> --- linux-2.4.18-pre8/fs/ext3/inode.c Tue Feb 5 00:33:05 2002
> +++ linux-akpm/fs/ext3/inode.c Wed Feb 6 23:40:48 2002
> @@ -581,8 +581,6 @@ static int ext3_alloc_branch(handle_t *h
>
> parent = nr;
> }
> - if (IS_SYNC(inode))
> - handle->h_sync = 1;
> }
> if (n == num)
> return 0;
OK. This was just a relic of ages back when we had an overarching
transaction spanning multiple writepages in ext3_file_write(). In
that case, setting that transaction to be synchronous multiple times
was no extra cost. Doing it just once at the end should be fine.
Cheers,
Stephen
next prev parent reply other threads:[~2002-03-25 23:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-24 21:50 [patch] speed up ext3 synchronous mounts Andrew Morton
2002-03-25 23:01 ` Stephen C. Tweedie [this message]
2002-03-27 19:07 ` Matthias Andree
2002-03-27 19:13 ` Ed Sweetman
2002-03-27 19:17 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020325230114.N4328@redhat.com \
--to=sct@redhat.com \
--cc=akpm@zip.com.au \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox