Re: [PATCH] 3c59x and resume

["christophe barbé" <christophe.barbe.ml@online.fr>]

[-- Attachment #1: Type: text/plain, Size: 2436 bytes --]

On Mon, Mar 25, 2002 at 07:57:19PM -0500, Jeff Garzik wrote:
> This patch causes module defaults to be reused -- potentially incorrectly.

Wrong. How can the fact that a suspend/resume cycle increment the id be
worst than the fact that the same cycle return idx to the previous
state?

The argument you have against this patch is WRONG.

You think about NICs in a PCI slot. 
That's changed the day the cardbus support was moved from pcmcia to the
today implementation.
You can't expect cardbus user to stop using the suspend mode because you
expect your id to be attributed one time (that doesn't even make sense).

I agree that this patch is not a full fix (I said it in my original
post) but I disagree that it does any bad things. I would be interested
to learn about a real case ?

But ethtool seems to be very interesting and it looks like what I was
looking for. I will have a closer look at it, thank you for pointing it
to me.

> This is a personal solution, that might live on temporary as an 
> outside-the-tree patch... but we cannot apply this to the stable kernel.
> 
> I agree the card idx is wrong on remove.  Insert and remove a 3c59x 
> cardbus card several times, and you will lose your module options too. 

NO -- If I can remove/insert suspend/remove my card as I want I ever get
the same ID. 
If you want to fail the patch you need to remove/insert 2 cards in FILO
order. Then you will get a ever bigger ID but this is what you get by
default without the patch.

> However... take note that this problem cannot be solved "the easy way" 
> -- because one solution people may desire will potentially result in 
> module options getting re-used incorrectly.  The above is one such solution.

I am waiting for a real case.

> If you want WOL options to "stick" or vary per-interface, we already 
> have an API for that -- ethtool.  Check out drivers/net/natsemi.c for an 
> example implementation.  _Tested_ patches to 3c59x that add WOL ethtool 
> support are welcome, pending Andrew's approval.  Do not remove 
> enable_wol for now in a stable series, but we will deprecate its use 
> once ethtool support appears.

Noted.

Christophe

>    Jeff

-- 
Christophe Barbé <christophe.barbe@ufies.org>
GnuPG FingerPrint: E0F6 FADF 2A5C F072 6AF8  F67A 8F45 2F1E D72C B41E

Dogs come when they're called;
cats take a message and get back to you later. --Mary Bly

[-- Attachment #2: Type: application/pgp-signature, Size: 241 bytes --]