Re: [PATCH][RFC] P4/Xeon Thermal LVT support

Maciej W. Rozycki
2002-03-27T15:24:30Z

On Wed, 27 Mar 2002, Zwane Mwaikambo wrote:

> > > #define FIRST_DEVICE_VECTOR 0x31
> > > +#define THERMAL_APIC_VECTOR 0x32 /* Thermal monitor local vector */
> > > #define FIRST_SYSTEM_VECTOR 0xef
> >
> > You certainly want to select a different vector.
>
> Whats wrong with that vector? I tried to follow the guidelines as
> specified in hw_irq.h and opted to go for the lower priority ones, or
> is the vector not serviceable due to its range?

You can't use a vector that is in the range assigned to I/O APIC
interrupts (i.e. 0x31 - 0xee). Otherwise you'll get an overlap when the
vector gets assigned to an ordinary IRQ line. Also you probably want a
high-priority interrupt as the condition is serious, if not critical --
system failures, such as bus exceptions, machine check faults, parity
errors, power failures, etc. demand a high priority service.

--
+ Maciej W. Rozycki, Technical University of Gdansk, Poland +
+--------------------------------------------------------------+
+ e-mail: macro@ds2.pg.gda.pl, PGP key available +