Re: Linux 2.4.19-pre5: hotplug config

Greg KH
2002-03-31T17:54:24Z

On Sun, Mar 31, 2002 at 03:02:45PM +0100, Alan Cox wrote:
> > -dep_tristate ' IBM PCI Hotplug driver' CONFIG_HOTPLUG_PCI_IBM $CONFIG_HOTPLUG_PCI $CONFIG_X86_IO_APIC $CONFIG_X86
> > +if [ "$CONFIG_X86_IO_APIC" = "y" ]; then
> > + dep_tristate ' IBM PCI Hotplug driver' CONFIG_HOTPLUG_PCI_IBM $CONFIG_HOTPLUG_PCI $CONFIG_X86
> > +fi
>
> What if I want hot plug and no apic??

No, the IBM driver will not work without apic. Or at least that's what
the original authors of the driver told me :)

I thought the 'dep_tristate' rule would have caught this, but it looks
like this is the correct fix.

> See the fix in the 2.4.19-ac tree, that one ought to have been sufficient

I don't see a fix for this in your tree. I only see the static->global
variable fix there. Am I missing something?

thanks,

greg k-h