Re: [PATCH] radeonfb 2.4.19-pre2

[<benh@kernel.crashing.org>]

>Spurred on by a little positive feedback, I've added more stuff to my
>patch for the ATI Radeon frame buffer driver.

Could you CC the driver maintainer ? (ajoshi@unixbox.com) and me
on further updates please ? radeonfb is an important driver on PPC
boxes and some parts of it has to be handled with care ;)

>* Reinitialise accelerator on console switch. This ensures the
>accelerator is in a known state after X exits.

Sounds fine

>* Added acceleration functions for 15/16/32 bit modes.

Good ;)

>* Removed 24 bit support. It didn't work and the X source hints that
>Radeon might not support 24 bit modes. If you ask for a 24 bit mode, the
>driver will switch to a 32 bit one.

Yah, that never worked

>* Minor fix to video mode switch code which means 'fbset' now works
>correctly. This also means the 'UseFBDev' option in X works. Commented out
>a hack that looks like it was a failed attempt to work around this bug
>previously.

What was wrong ? I'm not sure what you mean, we have been using fbset
and UseFBDev for ages on PPC

>* Hacked wildly at the colour support to get it to work. Removed use of
>the palette for 15/16 bit modes (I can't fathom why it was there in the
>first place). The palette is now initialised to an identity mapping for
>15/16/32 bit modes. The consoles now work fine at all colour depths, and
>the Tux logo is displayed correctly at all depths too :-)

I don't agree here ! The palette _do_ make sense in 15/16/32, in which
case it's called gamma table. Don't break that, some apps do use it
(like MacOnLinux).

>* Added an untested fix for acceleration on flat panels. "Stuffed Crust"
>reported garbled display when acceleration was enabled, this might fix it.

I'll give it a try and let you know.

>* Other minor cleanups.

Can't harm ;)

Ben.