From: "David S. Miller" <davem@redhat.com>
To: kaber@trash.net
Cc: kuznet2@ms2.inr.ac.ru, linux-kernel@vger.kernel.org
Subject: Re: bug in sch_generic.c:pfifo_fast_enqueue
Date: Wed, 10 Apr 2002 21:41:12 -0700 (PDT) [thread overview]
Message-ID: <20020410.214112.10765569.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0204012131330.13230-200000@el-zoido.localnet>
From: Patrick McHardy <kaber@trash.net>
Date: Mon, 1 Apr 2002 21:43:03 +0200 (CEST)
I found a small bug in pfifo_fast_enqueue, instead of
if (list->qlen <= skb->dev->tx_queue_len)
it should be
if (list->qlen <= qdisc->dev->tx_queue_len)
i guess.
skb->dev == qdisc->dev should be invariant when this
code runs. So the code is correct, albeit possibly
confusing.
next prev parent reply other threads:[~2002-04-11 4:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-01 19:43 bug in sch_generic.c:pfifo_fast_enqueue Patrick McHardy
2002-04-11 4:41 ` David S. Miller [this message]
2002-04-11 13:56 ` Patrick McHardy
2002-04-24 17:51 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020410.214112.10765569.davem@redhat.com \
--to=davem@redhat.com \
--cc=kaber@trash.net \
--cc=kuznet2@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox