Re: [PATCH] Radeon frame buffer driver

[<benh@kernel.crashing.org>]

>Probably not (unless you can quote me on that :-)
>
>The color map is saved/restored in radeonfb_switch().
>
>Gr{oetje,eeting}s,

Yes, the console color map is, but isn't an fbdev app like MOL or
X supposed to restore it's own colormap when switched back in ?
Well, I may be able to quote you on this...

>>  - When using > 8 bit depth, who is supposed to set the linear
>>    gamma ramp ? (My understanding is that a client app is responsible
>>    to set it's own cmap properly, but it also looks like some apps
>>    rely on the default beeing set to a linear gamma ramp). Should
>>    I set it this way in set_par by default and then let the app
>>    eventually change it ?
>
>If your fbdev claims to be in truecolor mode, your fbdev should do it.
>If your fbdev claims to be in directcolor mode, the application should do it
>(if the app wants truecolor mode).

Ok, actually, you weren't talking about console switch. Though I'm pretty
sure MOL at least will properly restore it's colormap, I don't know for
XFree.

So Peter, it seems you have to save/restore it all finally.

Ben.