From: Mike Fedyk <mfedyk@matchmail.com>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch-2.5.8-pre] swapinfo accounting
Date: Wed, 10 Apr 2002 18:46:30 -0700 [thread overview]
Message-ID: <20020411014630.GK23513@matchmail.com> (raw)
In-Reply-To: <Pine.LNX.4.33L2.0204101755170.25409-100000@dragon.pdx.osdl.net>
On Wed, Apr 10, 2002 at 06:20:55PM -0700, Randy.Dunlap wrote:
> Anyway, here is the patch that makes it better.
> Not perfect, due to possibility of bad blocks, but better
> than it was. Comments?
>
>
> --- linux-258-pre2/mm/swapfile.c.SI Wed Apr 10 17:50:34 2002
> +++ linux-258-pre2/mm/swapfile.c Wed Apr 10 18:09:46 2002
> @@ -1107,8 +1107,8 @@
> }
> }
> }
> - val->freeswap = nr_swap_pages + nr_to_be_unused;
> - val->totalswap = total_swap_pages + nr_to_be_unused;
> + val->freeswap = nr_swap_pages;
> + val->totalswap = total_swap_pages;
> swap_list_unlock();
> }
Shouldn't that be s/+/-/ instead? If this is badblocks accounting, it
should probably be subtracted instead of added.
next prev parent reply other threads:[~2002-04-11 1:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-11 1:20 [patch-2.5.8-pre] swapinfo accounting Randy.Dunlap
2002-04-11 0:48 ` Andrew Morton
2002-04-11 3:52 ` rddunlap
2002-04-11 15:15 ` Hugh Dickins
2002-04-11 17:18 ` Randy.Dunlap
2002-04-11 1:46 ` Mike Fedyk [this message]
2002-04-11 3:57 ` rddunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020411014630.GK23513@matchmail.com \
--to=mfedyk@matchmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox