public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: "Ivan G." <ivangurdiev@yahoo.com>,
	Linus Torvalds <torvalds@transmeta.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: 2.5.8 compile bugs
Date: Mon, 15 Apr 2002 13:51:31 +0200	[thread overview]
Message-ID: <20020415115131.GN12608@suse.de> (raw)
In-Reply-To: <20020415070728.GB12608@suse.de> <Pine.LNX.4.21.0204151334350.26237-100000@serv>

On Mon, Apr 15 2002, Roman Zippel wrote:
> > This should fix it.
> > 
> > --- drivers/ide/ide.c~	2002-04-15 09:05:58.000000000 +0200
> > +++ drivers/ide/ide.c	2002-04-15 09:06:52.000000000 +0200
> > @@ -2701,7 +2701,11 @@
> >  
> >  void ide_teardown_commandlist(ide_drive_t *drive)
> >  {
> > +#ifdef CONFIG_BLK_DEV_IDEPCI
> >  	struct pci_dev *pdev= drive->channel->pci_dev;
> > +#else
> > +	struct pci_dev *pdev = NULL;
> > +#endif
> >  	struct list_head *entry;
> >  
> >  	list_for_each(entry, &drive->free_req) {
> > @@ -2716,7 +2720,11 @@
> >  
> >  int ide_build_commandlist(ide_drive_t *drive)
> >  {
> > +#ifdef CONFIG_BLK_DEV_IDEPCI
> >  	struct pci_dev *pdev= drive->channel->pci_dev;
> > +#else
> > +	struct pci_dev *pdev = NULL;
> > +#endif
> >  	struct ata_request *ar;
> >  	ide_tag_info_t *tcq;
> >  	int i, err;
> 
> That's not enough, some archs don't define pci_alloc_consistent/
> pci_free_consistent, because they have neither PCI nor ISA.

Please, then those archs need to provide similar functionality. This is
the established api, unless you want to change the documentation and xxx
number of drivers?

-- 
Jens Axboe


  reply	other threads:[~2002-04-15 11:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-14 22:48 2.5.8 compile bugs Ivan G.
2002-04-15  7:07 ` Jens Axboe
2002-04-15 11:47   ` Roman Zippel
2002-04-15 11:51     ` Jens Axboe [this message]
2002-04-15 12:04       ` Roman Zippel
2002-04-15 12:09         ` Jens Axboe
2002-04-15 12:31           ` Roman Zippel
2002-04-15 16:01           ` andrew may
2002-04-15 17:30       ` Roman Zippel
2002-04-15 17:32         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020415115131.GN12608@suse.de \
    --to=axboe@suse.de \
    --cc=ivangurdiev@yahoo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox